2022-05-16 07:35:39

by Jiapeng Chong

Subject: [PATCH] xfs: Remove duplicate include

Clean up the following includecheck warning:

./fs/xfs/xfs_attr_item.c: xfs_inode.h is included more than once.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/xfs/xfs_attr_item.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
index e8ac88d9fd14..bf9a01b083b8 100644
--- a/fs/xfs/xfs_attr_item.c
+++ b/fs/xfs/xfs_attr_item.c
@@ -22,7 +22,6 @@
#include "xfs_attr.h"
#include "xfs_attr_item.h"
#include "xfs_trace.h"
-#include "xfs_inode.h"
#include "xfs_trans_space.h"
#include "xfs_errortag.h"
#include "xfs_error.h"
--
2.20.1.7.g153144c

2022-05-17 01:00:18

by Darrick J. Wong

Subject: Re: [PATCH] xfs: Remove duplicate include

On Sun, May 15, 2022 at 09:11:40PM +0800, Jiapeng Chong wrote:
> Clean up the following includecheck warning:
>
> ./fs/xfs/xfs_attr_item.c: xfs_inode.h is included more than once.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

LGTM
Reviewed-by: Darrick J. Wong <[email protected]>

--D

> ---
> fs/xfs/xfs_attr_item.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/xfs/xfs_attr_item.c b/fs/xfs/xfs_attr_item.c
> index e8ac88d9fd14..bf9a01b083b8 100644
> --- a/fs/xfs/xfs_attr_item.c
> +++ b/fs/xfs/xfs_attr_item.c
> @@ -22,7 +22,6 @@
> #include "xfs_attr.h"
> #include "xfs_attr_item.h"
> #include "xfs_trace.h"
> -#include "xfs_inode.h"
> #include "xfs_trans_space.h"
> #include "xfs_errortag.h"
> #include "xfs_error.h"
> --
> 2.20.1.7.g153144c
>