2022-05-18 03:29:02

by Guo Zhengkui

Subject: [PATCH] ALSA: seq: replace ternary operator with max()

Fix the following coccicheck warning:

sound/core/seq/seq_ports.c:142:12-14: WARNING opportunity for max()

Signed-off-by: Guo Zhengkui <[email protected]>
---
sound/core/seq/seq_ports.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/seq/seq_ports.c b/sound/core/seq/seq_ports.c
index 84d78630463e..25fcf5a2c71c 100644
--- a/sound/core/seq/seq_ports.c
+++ b/sound/core/seq/seq_ports.c
@@ -139,7 +139,7 @@ struct snd_seq_client_port *snd_seq_create_port(struct snd_seq_client *client,
port_subs_info_init(&new_port->c_dest);
snd_use_lock_use(&new_port->use_lock);

- num = port >= 0 ? port : 0;
+ num = max(port, 0);
mutex_lock(&client->ports_mutex);
write_lock_irq(&client->ports_lock);
list_for_each_entry(p, &client->ports_list_head, list) {
--
2.20.1

2022-05-18 03:43:21

by Takashi Iwai

Subject: Re: [PATCH] ALSA: seq: replace ternary operator with max()

On Tue, 17 May 2022 08:25:17 +0200,
Guo Zhengkui wrote:
>
> Fix the following coccicheck warning:
>
> sound/core/seq/seq_ports.c:142:12-14: WARNING opportunity for max()
>
> Signed-off-by: Guo Zhengkui <[email protected]>

Thanks, applied now.


Takashi