Fix reg address typo in the gpio1 stanza.
Signed-off-by: Conor Paxton <[email protected]>
---
arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
index 746c4d4e7686..cf2f55e1dcb6 100644
--- a/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
+++ b/arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi
@@ -366,7 +366,7 @@ gpio0: gpio@20120000 {
gpio1: gpio@20121000 {
compatible = "microchip,mpfs-gpio";
- reg = <000 0x20121000 0x0 0x1000>;
+ reg = <0x0 0x20121000 0x0 0x1000>;
interrupt-parent = <&plic>;
interrupt-controller;
#interrupt-cells = <1>;
--
2.25.1
On 17/05/2022 12:40, Conor Paxton wrote:
> Fix reg address typo in the gpio1 stanza.
>
> Signed-off-by: Conor Paxton <[email protected]>
> ---
> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On 17/05/2022 16:53, Palmer Dabbelt wrote:
> On Tue, 17 May 2022 07:51:32 PDT (-0700), [email protected] wrote:
>> On 17/05/2022 12:40, Conor Paxton wrote:
>>> Fix reg address typo in the gpio1 stanza.
>>>
>>> Signed-off-by: Conor Paxton <[email protected]>
>>> ---
>>> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>>
>> Pressed send to fast...
>>
>> Please add Fixes tag, unless fixed commit SHA is not considered stable.
>
> Conor might be asleep, and as it's late in the cycle I figured I'd just chime in directly. This LGTM, I usually add fixes myself if there aren't any. Unless there's any objections to
It's not even 1700 yet, neither Conor on the mail is asleep!
>
> Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
Saw Krzysztof's mail as I went out the door, I was gonna add an RB & the fixes tag
once I got home but beaten to the punch.
FWIW at this point:
Reviewed-by: Conor Dooley <[email protected]>
>
> I'll put this on fixes.
>
> Thanks!
>
>
>>
>>
>> Best regards,
>> Krzysztof
On 17/05/2022 12:40, Conor Paxton wrote:
> Fix reg address typo in the gpio1 stanza.
>
> Signed-off-by: Conor Paxton <[email protected]>
> ---
> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
Pressed send to fast...
Please add Fixes tag, unless fixed commit SHA is not considered stable.
Best regards,
Krzysztof
On Tue, 17 May 2022 07:51:32 PDT (-0700), [email protected] wrote:
> On 17/05/2022 12:40, Conor Paxton wrote:
>> Fix reg address typo in the gpio1 stanza.
>>
>> Signed-off-by: Conor Paxton <[email protected]>
>> ---
>> arch/riscv/boot/dts/microchip/microchip-mpfs.dtsi | 2 +-
>
> Pressed send to fast...
>
> Please add Fixes tag, unless fixed commit SHA is not considered stable.
Conor might be asleep, and as it's late in the cycle I figured I'd just
chime in directly. This LGTM, I usually add fixes myself if there
aren't any. Unless there's any objections to
Fixes: 528a5b1f2556 ("riscv: dts: microchip: add new peripherals to icicle kit device tree")
I'll put this on fixes.
Thanks!
>
>
> Best regards,
> Krzysztof