2022-05-17 13:37:47

by Leo Yan

[permalink] [raw]
Subject: Re: [PATCH v2 3/4] perf tools: arm64: Decouple Libunwind register names from Perf

On Tue, May 17, 2022 at 11:20:04AM +0100, James Clark wrote:
> Dwarf register numbers and real register numbers on aarch64 are
> equivalent. Remove the references to the register names from
> Libunwind so that new registers are supported without having to
> add build time feature checks for each new register.
>
> The unwinder won't ask for a register that it doesn't know about
> and Perf will already report an error for an unknown or unrecorded
> register in the perf_reg_value() function so extra validation
> isn't needed.
>
> After this change the new VG register can be read by libunwind.
>
> Signed-off-by: James Clark <[email protected]>

Looks good to me:

Reviewed-by: Leo Yan <[email protected]>