2022-05-19 13:47:25

by Jiri Slaby

Subject: [PATCH 4/4] serial: pmac_zilog: remove initial print

Don't report about the driver when loaded. It's unneeded and frowned
upon nowadays.

Cc: Michael Ellerman <[email protected]>
Cc: Benjamin Herrenschmidt <[email protected]>
Cc: Paul Mackerras <[email protected]>
Signed-off-by: Jiri Slaby <[email protected]>
---
drivers/tty/serial/pmac_zilog.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c
index c6961f299f3b..3133446e806c 100644
--- a/drivers/tty/serial/pmac_zilog.c
+++ b/drivers/tty/serial/pmac_zilog.c
@@ -64,7 +64,6 @@

#include "pmac_zilog.h"

-static char version[] __initdata = "pmac_zilog: 0.6 (Benjamin Herrenschmidt <[email protected]>)";
MODULE_AUTHOR("Benjamin Herrenschmidt <[email protected]>");
MODULE_DESCRIPTION("Driver for the Mac and PowerMac serial ports.");
MODULE_LICENSE("GPL");
@@ -1812,7 +1811,6 @@ static struct platform_driver pmz_driver = {
static int __init init_pmz(void)
{
int rc, i;
- printk(KERN_INFO "%s\n", version);

/*
* First, we need to do a direct OF-based probe pass. We
--
2.36.1

2022-05-19 14:25:28

by Ilpo Järvinen

Subject: Re: [PATCH 4/4] serial: pmac_zilog: remove initial print

On Thu, 19 May 2022, Jiri Slaby wrote:

> Don't report about the driver when loaded. It's unneeded and frowned
> upon nowadays.
>
> Cc: Michael Ellerman <[email protected]>
> Cc: Benjamin Herrenschmidt <[email protected]>
> Cc: Paul Mackerras <[email protected]>
> Signed-off-by: Jiri Slaby <[email protected]>

Reviewed-by: Ilpo J?rvinen <[email protected]>

for patches 2-4.

--
i.