2022-05-19 14:11:12

by Tang Bin

Subject: [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe()

In the function xilinx_dpdma_probe(), when get irq failed,
the function platform_get_irq() logs an error message,
so remove redundant message here.

Signed-off-by: Tang Bin <[email protected]>
---
drivers/dma/xilinx/xilinx_dpdma.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/dma/xilinx/xilinx_dpdma.c b/drivers/dma/xilinx/xilinx_dpdma.c
index b0f4948b0..f708808d7 100644
--- a/drivers/dma/xilinx/xilinx_dpdma.c
+++ b/drivers/dma/xilinx/xilinx_dpdma.c
@@ -1652,10 +1652,8 @@ static int xilinx_dpdma_probe(struct platform_device *pdev)
dpdma_hw_init(xdev);

xdev->irq = platform_get_irq(pdev, 0);
- if (xdev->irq < 0) {
- dev_err(xdev->dev, "failed to get platform irq\n");
+ if (xdev->irq < 0)
return xdev->irq;
- }

ret = request_irq(xdev->irq, xilinx_dpdma_irq_handler, IRQF_SHARED,
dev_name(xdev->dev), xdev);
--
2.20.1.windows.1

2022-07-06 05:52:28

by Vinod Koul

Subject: Re: [PATCH] dmaengine: xilinx_dpdma: Omit superfluous error message in xilinx_dpdma_probe()

On 19-05-22, 21:08, Tang Bin wrote:
> In the function xilinx_dpdma_probe(), when get irq failed,
> the function platform_get_irq() logs an error message,
> so remove redundant message here.

Applied, thanks

--
~Vinod