2022-05-20 23:53:12

by Matthew Wilcox

Subject: Re: [PATCH v2 03/28] vsprintf: %pf(%p)

On Thu, May 19, 2022 at 01:23:56PM -0400, Kent Overstreet wrote:
> +++ b/Documentation/core-api/printk-formats.rst
> @@ -625,6 +625,25 @@ Examples::
> %p4cc Y10 little-endian (0x20303159)
> %p4cc NV12 big-endian (0xb231564e)
>
> +Calling a pretty printer function
> +---------------------------------
> +
> +::
> +
> + %p(%p) pretty printer function taking one argument
> + %p(%p,%p) pretty printer function taking two arguments

Needs to be updated to the %pf change.

> + printf("%p(%p)", foo_to_text, foo);

Likewise

Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>

2022-05-23 07:04:38

by Kent Overstreet

Subject: Re: [PATCH v2 03/28] vsprintf: %pf(%p)

On Thu, May 19, 2022 at 07:33:32PM +0100, Matthew Wilcox wrote:
> On Thu, May 19, 2022 at 01:23:56PM -0400, Kent Overstreet wrote:
> > +++ b/Documentation/core-api/printk-formats.rst
> > @@ -625,6 +625,25 @@ Examples::
> > %p4cc Y10 little-endian (0x20303159)
> > %p4cc NV12 big-endian (0xb231564e)
> >
> > +Calling a pretty printer function
> > +---------------------------------
> > +
> > +::
> > +
> > + %p(%p) pretty printer function taking one argument
> > + %p(%p,%p) pretty printer function taking two arguments
>
> Needs to be updated to the %pf change.
>
> > + printf("%p(%p)", foo_to_text, foo);
>
> Likewise
>
> Reviewed-by: Matthew Wilcox (Oracle) <[email protected]>

Thanks - fixed.