2022-05-21 16:48:02

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 0/3] riscv: Kconfig: Style cleanups

The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.

While at it:
- Add trailing comments to endif/endmenu statements for better
readability.

Juerg Haefliger (3):
riscv: Kconfig: Fix indentation and add comments
riscv: Kconfig.erratas: Add comments
riscv: Kconfig.socs: Add comments

arch/riscv/Kconfig | 19 +++++++++----------
arch/riscv/Kconfig.erratas | 2 +-
arch/riscv/Kconfig.socs | 4 ++--
3 files changed, 12 insertions(+), 13 deletions(-)

--
2.32.0



2022-05-22 20:51:44

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 3/3] riscv: Kconfig.socs: Add comments

Add trailing comments to endif and endmenu statements for better
readability.

Signed-off-by: Juerg Haefliger <[email protected]>
---
arch/riscv/Kconfig.socs | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index f6ef358d8a2c..c831609db249 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -79,6 +79,6 @@ config SOC_CANAAN_K210_DTB_SOURCE
for the DTS file that will be used to produce the DTB linked into the
kernel.

-endif
+endif # SOC_CANAAN

-endmenu
+endmenu # "SoC selection"
--
2.32.0


2022-05-23 07:28:26

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 2/3] riscv: Kconfig.erratas: Add comments

Add trailing comments to endmenu statements for better readability.

Signed-off-by: Juerg Haefliger <[email protected]>
---
arch/riscv/Kconfig.erratas | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/Kconfig.erratas b/arch/riscv/Kconfig.erratas
index 0aacd7052585..076005c5dad5 100644
--- a/arch/riscv/Kconfig.erratas
+++ b/arch/riscv/Kconfig.erratas
@@ -42,4 +42,4 @@ config ERRATA_SIFIVE_CIP_1200

If you don't know what to do here, say "Y".

-endmenu
+endmenu # "CPU errata selection"
--
2.32.0


2022-07-01 04:29:52

by Palmer Dabbelt

[permalink] [raw]
Subject: Re: [PATCH 0/3] riscv: Kconfig: Style cleanups

On Fri, 20 May 2022 05:02:29 PDT (-0700), [email protected] wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
>
> While at it:
> - Add trailing comments to endif/endmenu statements for better
> readability.
>
> Juerg Haefliger (3):
> riscv: Kconfig: Fix indentation and add comments
> riscv: Kconfig.erratas: Add comments
> riscv: Kconfig.socs: Add comments
>
> arch/riscv/Kconfig | 19 +++++++++----------
> arch/riscv/Kconfig.erratas | 2 +-
> arch/riscv/Kconfig.socs | 4 ++--
> 3 files changed, 12 insertions(+), 13 deletions(-)

Thanks, this is on for-next. There were a few merge conflicts,
everything looks pretty straight-forward but let me know if there were
any issues.