2022-05-21 11:29:42

by Matthias Kaehlcke

Subject: [PATCH] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager

Villager has a backlit keyboard, enable support for the backlight.

Signed-off-by: Matthias Kaehlcke <[email protected]>
---

arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 8 ++++++++
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
index d3d6ffad4eff..b6a6a1454883 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
@@ -58,6 +58,10 @@ &ap_sar_sensor1 {
status = "okay";
};

+&keyboard_backlight {
+ status = "okay";
+};
+
&mdss_edp {
status = "okay";
};
@@ -76,6 +80,10 @@ &pcie1_phy {
status = "okay";
};

+&pwmleds {
+ status = "okay";
+};
+
/* For eMMC */
&sdhc_1 {
status = "okay";
diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9cb1bc8ed6b5..4b8bdcd6d9f4 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -295,7 +295,7 @@ pp1200_wf_cam: pp1200-wf-cam-regulator {

/* BOARD-SPECIFIC TOP LEVEL NODES */

- pwmleds {
+ pwmleds: pwmleds {
compatible = "pwm-leds";
status = "disabled";
keyboard_backlight: keyboard-backlight {
--
2.36.1.124.g0e6072fb45-goog

2022-05-23 07:57:22

by Doug Anderson

Subject: Re: [PATCH] arm64: dts: qcom: sc7280: Enable keyboard backlight for villager

Hi,

On Fri, May 20, 2022 at 12:48 PM Matthias Kaehlcke <[email protected]> wrote:
>
> Villager has a backlit keyboard, enable support for the backlight.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> ---
>
> arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts | 8 ++++++++
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 2 +-
> 2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> index d3d6ffad4eff..b6a6a1454883 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-villager-r0.dts
> @@ -58,6 +58,10 @@ &ap_sar_sensor1 {
> status = "okay";
> };
>
> +&keyboard_backlight {
> + status = "okay";
> +};

Instead of doing this, can you just get rid of the status = "disabled"
in herobrine.dtsi? I don't think there's any benefit to having two
levels of "disabled" in the herobrine device tree.