2022-05-23 07:30:55

by Tamseel Shams

Subject: [PATCH v2 0/3] Adds support of ADC for FSD SoC

This series of 3 patches adds support to ADC driver for
FSD SoC, and also adds nodes in device tree. These patches
were a part of large set of patches related to FSD SoC, but
these are posted now separately as per review comments received.

M Tamseel Shams (3):
dt-bindings: iio: adc: Add FSD-HW variant
iio: adc: exynos-adc: Add support for ADC FSD-HW controller
arm64: dts: fsd: Add ADC device tree node

.../bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++
arch/arm64/boot/dts/tesla/fsd.dtsi | 11 ++++
drivers/iio/adc/exynos_adc.c | 55 +++++++++++++++++++
4 files changed, 71 insertions(+)

--
2.17.1

2022-05-23 08:08:24

by Tamseel Shams

Subject: [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node

From: Alim Akhtar <[email protected]>

This patch adds ADC device tree node and enables the same
on fsd platform.

Signed-off-by: Alim Akhtar <[email protected]>
Signed-off-by: Tamseel Shams <[email protected]>
---
- Changes since v1
* Addressed Krzysztof's comment for corrections in dt files

arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++
arch/arm64/boot/dts/tesla/fsd.dtsi | 11 +++++++++++
2 files changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
index 5af560c1b5e6..63f26a85053a 100644
--- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
+++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
@@ -34,6 +34,10 @@
clock-frequency = <24000000>;
};

+&adc {
+ status = "okay";
+};
+
&serial_0 {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index 9a652abcbcac..f63624f2f414 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -748,6 +748,17 @@
clocks = <&fin_pll>, <&clock_imem IMEM_MCT_PCLK>;
clock-names = "fin_pll", "mct";
};
+
+ adc: adc@141a0000 {
+ compatible = "samsung,exynos-adc-fsd-hw";
+ reg = <0x0 0x141a0000 0x0 0x100>;
+ interrupts = <GIC_SPI 173 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clock_peric PERIC_PCLK_ADCIF>;
+ clock-names = "adc";
+ #io-channel-cells = <1>;
+ io-channel-ranges;
+ status = "disabled";
+ };
};
};

--
2.17.1

2022-05-23 10:22:28

by Krzysztof Kozlowski

Subject: Re: [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node

On 20/05/2022 16:58, Tamseel Shams wrote:
> From: Alim Akhtar <[email protected]>
>
> This patch adds ADC device tree node and enables the same
> on fsd platform.
>
> Signed-off-by: Alim Akhtar <[email protected]>
> Signed-off-by: Tamseel Shams <[email protected]>
> ---
> - Changes since v1
> * Addressed Krzysztof's comment for corrections in dt files
>
> arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++
> arch/arm64/boot/dts/tesla/fsd.dtsi | 11 +++++++++++
> 2 files changed, 15 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 5af560c1b5e6..63f26a85053a 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -34,6 +34,10 @@
> clock-frequency = <24000000>;
> };
>
> +&adc {
> + status = "okay";

Please test your bindings (`make dtbs_check`). There is no way it passes
since you miss at least supply (maybe more?).




Best regards,
Krzysztof

2022-06-01 20:37:41

by Tamseel Shams

Subject: RE: [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node

Hi Krzysztof,

On 20/05/2022 16:58, Tamseel Shams wrote:
>> From: Alim Akhtar <[email protected]>
>>
>> This patch adds ADC device tree node and enables the same on fsd
>> platform.
>>
>> Signed-off-by: Alim Akhtar <[email protected]>
>> Signed-off-by: Tamseel Shams <[email protected]>
>> ---
>> - Changes since v1
>> * Addressed Krzysztof's comment for corrections in dt files
>>
>> arch/arm64/boot/dts/tesla/fsd-evb.dts | 4 ++++
>> arch/arm64/boot/dts/tesla/fsd.dtsi | 11 +++++++++++
>> 2 files changed, 15 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
>> b/arch/arm64/boot/dts/tesla/fsd-evb.dts
>> index 5af560c1b5e6..63f26a85053a 100644
>> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
>> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
>> @@ -34,6 +34,10 @@
>> clock-frequency = <24000000>;
>> };
>>
>> +&adc {
>> + status = "okay";
>
> Please test your bindings (`make dtbs_check`). There is no way it passes since you miss at least supply (maybe more?).

Will add the "supply" field in dtsi file. Also will run dtbs check to see for any other missing field.


Thanks & Regards,
Tamseel Shams