2022-05-23 00:44:28

by Herve Codina

Subject: [PATCH 0/3] Microchip LAN966x USB device support

Hi,

This series add support for the USB device controller available on
the Microchip LAN966x SOCs (LAN9662 and LAN9668).

Both SOCs have the same controller and this controller is also the
same as the one present on the SAMAD3 SOC.

Regards,
Herve

Changes v2:
- Avoid wildcards in the DT compatible string
- Rename the DT node

Herve Codina (3):
clk: lan966x: Fix the lan966x clock gate register address
dt-bindings: usb: atmel: Add Microchip LAN9662 compatible string
ARM: dts: lan966x: Add UDPHS support

Documentation/devicetree/bindings/usb/atmel-usb.txt | 3 +++
arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
drivers/clk/clk-lan966x.c | 2 +-
3 files changed, 15 insertions(+), 1 deletion(-)

--
2.35.1

2022-05-23 07:05:26

by Herve Codina

Subject: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

Add UDPHS (the USB High Speed Device Port controller) support.

The both lan966x SOCs (LAN9662 and LAN9668) have the same UDPHS
IP. This IP is also the same as the one present in the SAMA5D3
SOC.

Signed-off-by: Herve Codina <[email protected]>
---
arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
index 7d2869648050..8313e71ecc37 100644
--- a/arch/arm/boot/dts/lan966x.dtsi
+++ b/arch/arm/boot/dts/lan966x.dtsi
@@ -211,6 +211,17 @@ can0: can@e081c000 {
status = "disabled";
};

+ udc: usb@e0808000 {
+ compatible = "microchip,lan9662-udc",
+ "atmel,sama5d3-udc";
+ reg = <0x00200000 0x80000>,
+ <0xe0808000 0x400>;
+ interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clks GCK_GATE_UDPHS>, <&nic_clk>;
+ clock-names = "pclk", "hclk";
+ status = "disabled";
+ };
+
gpio: pinctrl@e2004064 {
compatible = "microchip,lan966x-pinctrl";
reg = <0xe2004064 0xb4>,
--
2.35.1

2022-05-23 07:27:56

by Krzysztof Kozlowski

Subject: Re: [PATCH 0/3] Microchip LAN966x USB device support

On 20/05/2022 17:23, Herve Codina wrote:
> Hi,
>
> This series add support for the USB device controller available on
> the Microchip LAN966x SOCs (LAN9662 and LAN9668).
>
> Both SOCs have the same controller and this controller is also the
> same as the one present on the SAMAD3 SOC.
>
> Regards,
> Herve
>
> Changes v2:
> - Avoid wildcards in the DT compatible string
> - Rename the DT node

Thanks for changes. Please mark your patches as v2. The easiest is with
`git format-patch`.


Best regards,
Krzysztof

2022-05-23 08:44:56

by Claudiu Beznea

Subject: Re: [PATCH 3/3] ARM: dts: lan966x: Add UDPHS support

On 20.05.2022 18:23, Herve Codina wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Add UDPHS (the USB High Speed Device Port controller) support.
>
> The both lan966x SOCs (LAN9662 and LAN9668) have the same UDPHS
> IP. This IP is also the same as the one present in the SAMA5D3
> SOC.
>
> Signed-off-by: Herve Codina <[email protected]>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 11 +++++++++++
> 1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index 7d2869648050..8313e71ecc37 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -211,6 +211,17 @@ can0: can@e081c000 {
> status = "disabled";
> };
>
> + udc: usb@e0808000 {

Please keep the nodes ordered by their base addresses. 0xe0808000 is lower
than 0xe081c000 above.


> + compatible = "microchip,lan9662-udc",
> + "atmel,sama5d3-udc";
> + reg = <0x00200000 0x80000>,
> + <0xe0808000 0x400>;
> + interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&clks GCK_GATE_UDPHS>, <&nic_clk>;
> + clock-names = "pclk", "hclk";
> + status = "disabled";
> + };
> +
> gpio: pinctrl@e2004064 {
> compatible = "microchip,lan966x-pinctrl";
> reg = <0xe2004064 0xb4>,
> --
> 2.35.1
>