2022-05-23 07:00:43

by SEO HOYOUNG

Subject: [RESEND PATCH v1] scsi: ufs: Change the shutting_down flag setting position

When System shutdown, will called ufshcd_wl_shutdown().
Then the shutting_down falg set to 1 at ufshcd_wl_shutdown().
And send to SSU cmd at ufshcd_wl_shutdown()->__ufshcd_wl_suspend()->
ufshcd_set_dev_pwr_mode() function.

If occurred fail during send SSU cmd,
then will called ufshcd_err_handler for recovery.
But already set shutting_down to 1, so ufs driver could not recovery.
Then System wait for SSU cmd to be completed and
eventaully it will tak Hang.
So changed the position where shutting_down is set.

Signed-off-by: SEO HOYOUNG <[email protected]>
---
drivers/scsi/ufs/ufshcd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 1fb3a8b9b03e..65d47cd5afbe 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -9235,10 +9235,6 @@ static void ufshcd_wl_shutdown(struct device *dev)

hba = shost_priv(sdev->host);

- down(&hba->host_sem);
- hba->shutting_down = true;
- up(&hba->host_sem);
-
/* Turn on everything while shutting down */
ufshcd_rpm_get_sync(hba);
scsi_device_quiesce(sdev);
@@ -9248,6 +9244,10 @@ static void ufshcd_wl_shutdown(struct device *dev)
scsi_device_quiesce(sdev);
}
__ufshcd_wl_suspend(hba, UFS_SHUTDOWN_PM);
+
+ down(&hba->host_sem);
+ hba->shutting_down = true;
+ up(&hba->host_sem);
}

/**
--
2.26.0

2022-05-23 08:14:56

by SEO HOYOUNG

Subject: RE: [RESEND PATCH v1] scsi: ufs: Change the shutting_down flag setting position

> -----Original Message-----
> From: SEO HOYOUNG [mailto:[email protected]]
> Sent: Monday, May 23, 2022 2:19 AM
> To: [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]; [email protected]; [email protected];
> [email protected]
> Cc: SEO HOYOUNG
> Subject: [RESEND PATCH v1] scsi: ufs: Change the shutting_down flag
> setting position
>
> When System shutdown, will called ufshcd_wl_shutdown().
> Then the shutting_down falg set to 1 at ufshcd_wl_shutdown().
> And send to SSU cmd at ufshcd_wl_shutdown()->__ufshcd_wl_suspend()->
> ufshcd_set_dev_pwr_mode() function.
>
> If occurred fail during send SSU cmd,
> then will called ufshcd_err_handler for recovery.
> But already set shutting_down to 1, so ufs driver could not recovery.
> Then System wait for SSU cmd to be completed and eventaully it will tak
> Hang.
> So changed the position where shutting_down is set.
>
> Signed-off-by: SEO HOYOUNG <[email protected]>
> ---
> drivers/scsi/ufs/ufshcd.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index
> 1fb3a8b9b03e..65d47cd5afbe 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -9235,10 +9235,6 @@ static void ufshcd_wl_shutdown(struct device *dev)
>
> hba = shost_priv(sdev->host);
>
> - down(&hba->host_sem);
> - hba->shutting_down = true;
> - up(&hba->host_sem);
> -
> /* Turn on everything while shutting down */
> ufshcd_rpm_get_sync(hba);
> scsi_device_quiesce(sdev);
> @@ -9248,6 +9244,10 @@ static void ufshcd_wl_shutdown(struct device *dev)
> scsi_device_quiesce(sdev);
> }
> __ufshcd_wl_suspend(hba, UFS_SHUTDOWN_PM);
> +
> + down(&hba->host_sem);
> + hba->shutting_down = true;
> + up(&hba->host_sem);
> }
>
> /**
> --
> 2.26.0

Hi,

It seems that same patch below this.
https://lore.kernel.org/lkml/[email protected]/

I think that will occurred error with called __ufshcd_wl_suspend().

So the hba->shutting_down need to set after call __ufshcd_wl_suspend().
Otherwise, the error_handler cannot operate when an error occurs.
Please give opinion.

Thanks.