2022-05-23 15:34:26

by Miaoqian Lin

Subject: [PATCH] bus: arm-integrator-lm: Fix refcount leak in integrator_ap_lm_probe

of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/bus/arm-integrator-lm.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm-integrator-lm.c
index 2344d560b144..ab5fad8aaa99 100644
--- a/drivers/bus/arm-integrator-lm.c
+++ b/drivers/bus/arm-integrator-lm.c
@@ -85,6 +85,7 @@ static int integrator_ap_lm_probe(struct platform_device *pdev)
return -ENODEV;
}
map = syscon_node_to_regmap(syscon);
+ of_node_put(syscon);
if (IS_ERR(map)) {
dev_err(dev,
"could not find Integrator/AP system controller\n");
--
2.25.1

2022-06-04 08:07:37

by Linus Walleij

Subject: Re: [PATCH] bus: arm-integrator-lm: Fix refcount leak in integrator_ap_lm_probe

On Mon, May 23, 2022 at 5:34 PM Miaoqian Lin <[email protected]> wrote:

> of_find_matching_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: ccea5e8a5918 ("bus: Add driver for Integrator/AP logic modules")
> Signed-off-by: Miaoqian Lin <[email protected]>

Patch applied!

Yours,
Linus Walleij