2022-05-24 03:25:24

by Sungjong Seo

Subject: [PATCH] f2fs: allow compression for mmap files in compress_mode=user

Since commit e3c548323d32 ("f2fs: let's allow compression for mmap files"),
it has been allowed to compress mmap files. However, in compress_mode=user,
it is not allowed yet. To keep the same concept in both compress_modes,
f2fs_ioc_(de)compress_file() should also allow it.

Let's remove checking mmap files in f2fs_ioc_(de)compress_file() so that
the compression for mmap files is also allowed in compress_mode=user.

Signed-off-by: Sungjong Seo <[email protected]>
---
fs/f2fs/file.c | 10 ----------
1 file changed, 10 deletions(-)

diff --git a/fs/f2fs/file.c b/fs/f2fs/file.c
index 7aac53ac5acf..a05d842a7e72 100644
--- a/fs/f2fs/file.c
+++ b/fs/f2fs/file.c
@@ -3945,11 +3945,6 @@ static int f2fs_ioc_decompress_file(struct file *filp, unsigned long arg)
goto out;
}

- if (f2fs_is_mmap_file(inode)) {
- ret = -EBUSY;
- goto out;
- }
-
ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
if (ret)
goto out;
@@ -4017,11 +4012,6 @@ static int f2fs_ioc_compress_file(struct file *filp, unsigned long arg)
goto out;
}

- if (f2fs_is_mmap_file(inode)) {
- ret = -EBUSY;
- goto out;
- }
-
ret = filemap_write_and_wait_range(inode->i_mapping, 0, LLONG_MAX);
if (ret)
goto out;
--
2.25.1

2022-05-25 10:48:34

by Chao Yu

Subject: Re: [PATCH] f2fs: allow compression for mmap files in compress_mode=user

On 2022/5/24 9:29, Sungjong Seo wrote:
> Since commit e3c548323d32 ("f2fs: let's allow compression for mmap files"),
> it has been allowed to compress mmap files. However, in compress_mode=user,
> it is not allowed yet. To keep the same concept in both compress_modes,
> f2fs_ioc_(de)compress_file() should also allow it.
>
> Let's remove checking mmap files in f2fs_ioc_(de)compress_file() so that
> the compression for mmap files is also allowed in compress_mode=user.
>
> Signed-off-by: Sungjong Seo <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,