2022-05-24 16:44:22

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 0/3] m68k: Kconfig: Style cleanups

The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.

While at it, replace single quotes with double quotes, add missing endif
comments and squeeze multiple empty lines.

Juerg Haefliger (3):
m68k: Kconfig.cpu: Fix indentation and add endif comments
m68k: Kconfig.debug: Replace single quotes
m68k: Kconfig.machine: Add endif comment

arch/m68k/Kconfig.cpu | 7 +++----
arch/m68k/Kconfig.debug | 6 +++---
arch/m68k/Kconfig.machine | 2 +-
3 files changed, 7 insertions(+), 8 deletions(-)

--
2.32.0



2022-05-24 22:30:28

by Juerg Haefliger

[permalink] [raw]
Subject: [PATCH 2/3] m68k: Kconfig.debug: Replace single quotes

Replace single quotes in strings with double quotes to match the majority
of the rest of the kernel's Kconfig files.

Signed-off-by: Juerg Haefliger <[email protected]>
---
arch/m68k/Kconfig.debug | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/m68k/Kconfig.debug b/arch/m68k/Kconfig.debug
index 11b306bdd788..465e28be0ce4 100644
--- a/arch/m68k/Kconfig.debug
+++ b/arch/m68k/Kconfig.debug
@@ -1,11 +1,11 @@
# SPDX-License-Identifier: GPL-2.0

config BOOTPARAM
- bool 'Compiled-in Kernel Boot Parameter'
+ bool "Compiled-in Kernel Boot Parameter"

config BOOTPARAM_STRING
- string 'Kernel Boot Parameter'
- default 'console=ttyS0,19200'
+ string "Kernel Boot Parameter"
+ default "console=ttyS0,19200"
depends on BOOTPARAM

config EARLY_PRINTK
--
2.32.0


2022-07-06 09:41:38

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH 2/3] m68k: Kconfig.debug: Replace single quotes

On Tue, May 24, 2022 at 10:03 AM Juerg Haefliger
<[email protected]> wrote:
> Replace single quotes in strings with double quotes to match the majority
> of the rest of the kernel's Kconfig files.
>
> Signed-off-by: Juerg Haefliger <[email protected]>

Reviewed-by: Geert Uytterhoeven <[email protected]>
i.e. will queue in the m68k for-v5.20 branch.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds