2022-05-26 07:32:39

by Nobuhiro Iwamatsu

Subject: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

The clock for this driver switched to the common clock controller driver.
Therefore, update common clock properties for watchdog in the binding document.
And this matched this example with the actual dts.

Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
Acked-by: Rob Herring <[email protected]>
---

v3: doesn't remove timeout-sec.
v2: send to linux-watchdog.

.../bindings/watchdog/toshiba,visconti-wdt.yaml | 12 ++++--------
1 file changed, 4 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
index 690e19ce4b87..eba083822d1f 100644
--- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
+++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
@@ -35,20 +35,16 @@ additionalProperties: false

examples:
- |
+ #include <dt-bindings/clock/toshiba,tmpv770x.h>
+
soc {
#address-cells = <2>;
#size-cells = <2>;

- wdt_clk: wdt-clk {
- compatible = "fixed-clock";
- clock-frequency = <150000000>;
- #clock-cells = <0>;
- };
-
- watchdog@28330000 {
+ wdt: watchdog@28330000 {
compatible = "toshiba,visconti-wdt";
reg = <0 0x28330000 0 0x1000>;
- clocks = <&wdt_clk>;
timeout-sec = <20>;
+ clocks = <&pismu TMPV770X_CLK_WDTCLK>;
};
};
--
2.36.0

2022-09-25 14:50:08

by Guenter Roeck

Subject: Re: [PATCH v3] dt-bindings: watchdog: toshiba,visconti-wdt: Update the common clock properties

On Wed, May 25, 2022 at 09:46:05AM +0900, Nobuhiro Iwamatsu wrote:
> The clock for this driver switched to the common clock controller driver.
> Therefore, update common clock properties for watchdog in the binding document.
> And this matched this example with the actual dts.
>
> Signed-off-by: Nobuhiro Iwamatsu <[email protected]>
> Acked-by: Rob Herring <[email protected]>

Reviewed-by: Guenter Roeck <[email protected]>

> ---
>
> v3: doesn't remove timeout-sec.
> v2: send to linux-watchdog.
>
> .../bindings/watchdog/toshiba,visconti-wdt.yaml | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> index 690e19ce4b87..eba083822d1f 100644
> --- a/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> +++ b/Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml
> @@ -35,20 +35,16 @@ additionalProperties: false
>
> examples:
> - |
> + #include <dt-bindings/clock/toshiba,tmpv770x.h>
> +
> soc {
> #address-cells = <2>;
> #size-cells = <2>;
>
> - wdt_clk: wdt-clk {
> - compatible = "fixed-clock";
> - clock-frequency = <150000000>;
> - #clock-cells = <0>;
> - };
> -
> - watchdog@28330000 {
> + wdt: watchdog@28330000 {
> compatible = "toshiba,visconti-wdt";
> reg = <0 0x28330000 0 0x1000>;
> - clocks = <&wdt_clk>;
> timeout-sec = <20>;
> + clocks = <&pismu TMPV770X_CLK_WDTCLK>;
> };
> };