2022-05-25 09:05:05

by Judy Hsiao

[permalink] [raw]
Subject: [v3 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1

1. Add drive strength property for mi2s1 on sc7280 based platforms.
2. Disable the pull-up for mi2s1 lines.

Signed-off-by: Judy Hsiao <[email protected]>
---
arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 15 +++++++++++++++
1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
index 9cb1bc8ed6b5..f3044b39ba66 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
@@ -612,6 +612,21 @@ &dp_hot_plug_det {
bias-disable;
};

+&mi2s1_data0 {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_sclk {
+ drive-strength = <6>;
+ bias-disable;
+};
+
+&mi2s1_ws {
+ drive-strength = <6>;
+ bias-disable;
+};
+
&pcie1_clkreq_n {
bias-pull-up;
drive-strength = <2>;
--
2.36.1.124.g0e6072fb45-goog



2022-05-25 22:28:00

by Doug Anderson

[permalink] [raw]
Subject: Re: [v3 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1

Hi,

On Tue, May 24, 2022 at 6:43 PM Judy Hsiao <[email protected]> wrote:
>
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disable the pull-up for mi2s1 lines.
>
> Signed-off-by: Judy Hsiao <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)

Reviewed-by: Douglas Anderson <[email protected]>

2022-05-26 17:36:44

by Matthias Kaehlcke

[permalink] [raw]
Subject: Re: [v3 1/3] arm64: dts: qcom: sc7280: herobrine: Add pinconf settings for mi2s1

On Wed, May 25, 2022 at 01:43:06AM +0000, Judy Hsiao wrote:
> 1. Add drive strength property for mi2s1 on sc7280 based platforms.
> 2. Disable the pull-up for mi2s1 lines.
>
> Signed-off-by: Judy Hsiao <[email protected]>

You already had my 'Reviewed-by' tag for version 1 and 2, please make
sure to include these tags when you post a new version (unless there
are significant changes). That way maintainers can see that a patch
has been reviewed previously, without having to go through the entire
patch history, which they are unlikely to do. And your reviewer don't
want to be burdened either with having to send the tags over and over
again :)

Reviewed-by: Matthias Kaehlcke <[email protected]>