2022-05-26 04:29:01

by Miaoqian Lin

[permalink] [raw]
Subject: [PATCH] drm/mcde: Fix refcount leak in mcde_dsi_bind

Every iteration of for_each_available_child_of_node() decrements
the reference counter of the previous node. There is no decrement
when break out from the loop and results in refcount leak.
Add missing of_node_put() to fix this.

Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Miaoqian Lin <[email protected]>
---
drivers/gpu/drm/mcde/mcde_dsi.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c b/drivers/gpu/drm/mcde/mcde_dsi.c
index 5651734ce977..9f9ac8699310 100644
--- a/drivers/gpu/drm/mcde/mcde_dsi.c
+++ b/drivers/gpu/drm/mcde/mcde_dsi.c
@@ -1111,6 +1111,7 @@ static int mcde_dsi_bind(struct device *dev, struct device *master,
bridge = of_drm_find_bridge(child);
if (!bridge) {
dev_err(dev, "failed to find bridge\n");
+ of_node_put(child);
return -EINVAL;
}
}
--
2.25.1



2022-06-27 08:38:53

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH] drm/mcde: Fix refcount leak in mcde_dsi_bind

On Wed, May 25, 2022 at 1:54 PM Miaoqian Lin <[email protected]> wrote:

> Every iteration of for_each_available_child_of_node() decrements
> the reference counter of the previous node. There is no decrement
> when break out from the loop and results in refcount leak.
> Add missing of_node_put() to fix this.
>
> Fixes: 5fc537bfd000 ("drm/mcde: Add new driver for ST-Ericsson MCDE")
> Signed-off-by: Miaoqian Lin <[email protected]>

Patch applied for next as nonurgent fix.

Yours,
Linus Walleij