2022-05-25 01:51:17

by Geert Uytterhoeven

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
<[email protected]> wrote:
> "make dt_binding_check":
>
> Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
>
> The first line of the description ends with a colon, hence the block
> needs to be marked with a "|".
>
> Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> Signed-off-by: Geert Uytterhoeven <[email protected]>
> ---
> Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-

Alexandru Ardelean's email address bounces, while he is listed as
a maintainer in several DT bindings files.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


2022-05-25 09:03:27

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

On Tue, 24 May 2022 16:30:18 +0200 Geert Uytterhoeven wrote:
> On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
> <[email protected]> wrote:
> > "make dt_binding_check":
> >
> > Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> >
> > The first line of the description ends with a colon, hence the block
> > needs to be marked with a "|".
> >
> > Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > ---
> > Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
>
> Alexandru Ardelean's email address bounces, while he is listed as
> a maintainer in several DT bindings files.

Let's CC Alexandru Tachici, maybe he knows if we need to update
and to what.

2022-05-26 11:05:18

by Alexandru Tachici

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: net: adin: Fix adi,phy-output-clock description syntax

> On Tue, 24 May 2022 16:30:18 +0200 Geert Uytterhoeven wrote:
> > On Tue, May 24, 2022 at 4:12 PM Geert Uytterhoeven
> > <[email protected]> wrote:
> > > "make dt_binding_check":
> > >
> > > Documentation/devicetree/bindings/net/adi,adin.yaml:40:77: [error] syntax error: mapping values are not allowed here (syntax)
> > >
> > > The first line of the description ends with a colon, hence the block
> > > needs to be marked with a "|".
> > >
> > > Fixes: 1f77204e11f8b9e5 ("dt-bindings: net: adin: document phy clock output properties")
> > > Signed-off-by: Geert Uytterhoeven <[email protected]>
> > > ---
> > > Documentation/devicetree/bindings/net/adi,adin.yaml | 3 ++-
> >
> > Alexandru Ardelean's email address bounces, while he is listed as
> > a maintainer in several DT bindings files.
>
> Let's CC Alexandru Tachici, maybe he knows if we need to update
> and to what.

Yeah, I should have updated this one. You can add me instead or I will come back with a patch.

- Alexandru Tachici <[email protected]>

Regards,
Alexandru