Changes since v2:
* Add commit to fix header include path to use Perf's copy
* Apply Leo's review tags
When SVE registers are pushed onto the stack the VG register is required to
unwind because the stack offsets would vary by the SVE register width at the
time when the sample was taken.
The patches ("[PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding
through SVE functions") add support for sampling the VG register to the kernel
and the docs. This is the patchset to add support to userspace perf.
A small change is also required to libunwind or libdw depending on which
unwinder is used, and these will be published later. Without these changes Perf
continues to work with both libraries, although the VG register is still not
used for unwinding.
Thanks
James
James Clark (5):
perf tools: arm64: Use perf's copy of kernel headers
perf tools: arm64: Copy perf_regs.h from the kernel
perf tools: Use dynamic register set for Dwarf unwind
perf tools: arm64: Decouple Libunwind register names from Perf
perf tools: arm64: Add support for VG register
tools/arch/arm64/include/uapi/asm/perf_regs.h | 7 +-
tools/perf/arch/arm64/util/perf_regs.c | 34 +++++++++
tools/perf/arch/arm64/util/unwind-libunwind.c | 73 +------------------
tools/perf/util/evsel.c | 2 +-
tools/perf/util/libunwind/arm64.c | 2 +-
tools/perf/util/perf_regs.c | 2 +
6 files changed, 46 insertions(+), 74 deletions(-)
--
2.28.0
Fix this include path to use perf's copy of the kernel header
rather than the one from the root of the repo.
This fixes build errors when only applying the perf tools
part of a patchset rather than both sides.
Reported-by: German Gomez <[email protected]>
Signed-off-by: James Clark <[email protected]>
---
tools/perf/util/libunwind/arm64.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
index 15f60fd09424..014d82159656 100644
--- a/tools/perf/util/libunwind/arm64.c
+++ b/tools/perf/util/libunwind/arm64.c
@@ -24,7 +24,7 @@
#include "unwind.h"
#include "libunwind-aarch64.h"
#define perf_event_arm_regs perf_event_arm64_regs
-#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
+#include <../../../arch/arm64/include/uapi/asm/perf_regs.h>
#undef perf_event_arm_regs
#include "../../arch/arm64/util/unwind-libunwind.c"
--
2.28.0
On 25/05/2022 16:41, James Clark wrote:
> Fix this include path to use perf's copy of the kernel header
> rather than the one from the root of the repo.
>
> This fixes build errors when only applying the perf tools
> part of a patchset rather than both sides.
>
> Reported-by: German Gomez <[email protected]>
> Signed-off-by: James Clark <[email protected]>
Without this change "make -C tools/perf" was failing if kernel-side changes weren't applied
Tested-by: German Gomez <[email protected]>
Thanks,
German
> ---
> tools/perf/util/libunwind/arm64.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
> index 15f60fd09424..014d82159656 100644
> --- a/tools/perf/util/libunwind/arm64.c
> +++ b/tools/perf/util/libunwind/arm64.c
> @@ -24,7 +24,7 @@
> #include "unwind.h"
> #include "libunwind-aarch64.h"
> #define perf_event_arm_regs perf_event_arm64_regs
> -#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
> +#include <../../../arch/arm64/include/uapi/asm/perf_regs.h>
> #undef perf_event_arm_regs
> #include "../../arch/arm64/util/unwind-libunwind.c"
>
Em Wed, May 25, 2022 at 04:41:09PM +0100, James Clark escreveu:
> Changes since v2:
> * Add commit to fix header include path to use Perf's copy
> * Apply Leo's review tags
>
> When SVE registers are pushed onto the stack the VG register is required to
> unwind because the stack offsets would vary by the SVE register width at the
> time when the sample was taken.
>
> The patches ("[PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding
> through SVE functions") add support for sampling the VG register to the kernel
> and the docs. This is the patchset to add support to userspace perf.
>
> A small change is also required to libunwind or libdw depending on which
> unwinder is used, and these will be published later. Without these changes Perf
> continues to work with both libraries, although the VG register is still not
> used for unwinding.
Thanks, applied.
- Arnaldo
> Thanks
> James
>
> James Clark (5):
> perf tools: arm64: Use perf's copy of kernel headers
> perf tools: arm64: Copy perf_regs.h from the kernel
> perf tools: Use dynamic register set for Dwarf unwind
> perf tools: arm64: Decouple Libunwind register names from Perf
> perf tools: arm64: Add support for VG register
>
> tools/arch/arm64/include/uapi/asm/perf_regs.h | 7 +-
> tools/perf/arch/arm64/util/perf_regs.c | 34 +++++++++
> tools/perf/arch/arm64/util/unwind-libunwind.c | 73 +------------------
> tools/perf/util/evsel.c | 2 +-
> tools/perf/util/libunwind/arm64.c | 2 +-
> tools/perf/util/perf_regs.c | 2 +
> 6 files changed, 46 insertions(+), 74 deletions(-)
>
> --
> 2.28.0
--
- Arnaldo
On Wed, May 25, 2022 at 8:59 AM German Gomez <[email protected]> wrote:
>
>
> On 25/05/2022 16:41, James Clark wrote:
> > Fix this include path to use perf's copy of the kernel header
> > rather than the one from the root of the repo.
> >
> > This fixes build errors when only applying the perf tools
> > part of a patchset rather than both sides.
> >
> > Reported-by: German Gomez <[email protected]>
> > Signed-off-by: James Clark <[email protected]>
>
> Without this change "make -C tools/perf" was failing if kernel-side changes weren't applied
>
> Tested-by: German Gomez <[email protected]>
>
> Thanks,
> German
Acked-by: Ian Rogers <[email protected]>
Thanks,
Ian
> > ---
> > tools/perf/util/libunwind/arm64.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/libunwind/arm64.c b/tools/perf/util/libunwind/arm64.c
> > index 15f60fd09424..014d82159656 100644
> > --- a/tools/perf/util/libunwind/arm64.c
> > +++ b/tools/perf/util/libunwind/arm64.c
> > @@ -24,7 +24,7 @@
> > #include "unwind.h"
> > #include "libunwind-aarch64.h"
> > #define perf_event_arm_regs perf_event_arm64_regs
> > -#include <../../../../arch/arm64/include/uapi/asm/perf_regs.h>
> > +#include <../../../arch/arm64/include/uapi/asm/perf_regs.h>
> > #undef perf_event_arm_regs
> > #include "../../arch/arm64/util/unwind-libunwind.c"
> >
On 26/05/2022 16:23, Arnaldo Carvalho de Melo wrote:
> Em Wed, May 25, 2022 at 04:41:09PM +0100, James Clark escreveu:
>> Changes since v2:
>> * Add commit to fix header include path to use Perf's copy
>> * Apply Leo's review tags
>>
>> When SVE registers are pushed onto the stack the VG register is required to
>> unwind because the stack offsets would vary by the SVE register width at the
>> time when the sample was taken.
>>
>> The patches ("[PATCH v2 0/2] perf: arm64: Kernel support for Dwarf unwinding
>> through SVE functions") add support for sampling the VG register to the kernel
>> and the docs. This is the patchset to add support to userspace perf.
>>
>> A small change is also required to libunwind or libdw depending on which
>> unwinder is used, and these will be published later. Without these changes Perf
>> continues to work with both libraries, although the VG register is still not
>> used for unwinding.
>
> Thanks, applied.
>
> - Arnaldo
Hi Arnaldo,
Will has applied the kernel side here:
https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/commit/?h=for-next/perf&id=cbb0c02caf4bd98b9e0cd6d7420734b8e9a35703
There was a small change in the formatting in perf_regs.h, but the
values are all the same. So in theory it's fine to leave Perf's copy
until the next update, although it is a bit weird.
Thanks
James
>
>
>> Thanks
>> James
>>
>> James Clark (5):
>> perf tools: arm64: Use perf's copy of kernel headers
>> perf tools: arm64: Copy perf_regs.h from the kernel
>> perf tools: Use dynamic register set for Dwarf unwind
>> perf tools: arm64: Decouple Libunwind register names from Perf
>> perf tools: arm64: Add support for VG register
>>
>> tools/arch/arm64/include/uapi/asm/perf_regs.h | 7 +-
>> tools/perf/arch/arm64/util/perf_regs.c | 34 +++++++++
>> tools/perf/arch/arm64/util/unwind-libunwind.c | 73 +------------------
>> tools/perf/util/evsel.c | 2 +-
>> tools/perf/util/libunwind/arm64.c | 2 +-
>> tools/perf/util/perf_regs.c | 2 +
>> 6 files changed, 46 insertions(+), 74 deletions(-)
>>
>> --
>> 2.28.0
>