2022-05-30 13:31:36

by Weizhao Ouyang

Subject: [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend

Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.

Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
Signed-off-by: Weizhao Ouyang <[email protected]>
---
fs/erofs/zdata.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
index 95efc127b2ba..94d2cb970644 100644
--- a/fs/erofs/zdata.c
+++ b/fs/erofs/zdata.c
@@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {

#define DECOMPRESS_FRONTEND_INIT(__i) { \
.inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
- .mode = COLLECT_PRIMARY_FOLLOWED }
+ .mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }

static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
static DEFINE_MUTEX(z_pagemap_global_lock);
--
2.34.1

2022-05-30 18:13:39

by Gao Xiang

Subject: Re: [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend

On Mon, May 30, 2022 at 03:51:14PM +0800, Weizhao Ouyang wrote:
> Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.
>
> Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
> Signed-off-by: Weizhao Ouyang <[email protected]>


Many thanks for the in-time catching! ;)

Reviewed-by: Gao Xiang <[email protected]>

Thanks,
Gao Xiang

> ---
> fs/erofs/zdata.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/erofs/zdata.c b/fs/erofs/zdata.c
> index 95efc127b2ba..94d2cb970644 100644
> --- a/fs/erofs/zdata.c
> +++ b/fs/erofs/zdata.c
> @@ -214,7 +214,7 @@ struct z_erofs_decompress_frontend {
>
> #define DECOMPRESS_FRONTEND_INIT(__i) { \
> .inode = __i, .owned_head = Z_EROFS_PCLUSTER_TAIL, \
> - .mode = COLLECT_PRIMARY_FOLLOWED }
> + .mode = COLLECT_PRIMARY_FOLLOWED, .backmost = true }
>
> static struct page *z_pagemap_global[Z_EROFS_VMAP_GLOBAL_PAGES];
> static DEFINE_MUTEX(z_pagemap_global_lock);
> --
> 2.34.1

2022-06-01 18:40:20

by Chao Yu

Subject: Re: [PATCH] erofs: fix 'backmost' member of z_erofs_decompress_frontend

On 2022/5/30 15:51, Weizhao Ouyang wrote:
> Initialize 'backmost' to true in DECOMPRESS_FRONTEND_INIT.
>
> Fixes: 5c6dcc57e2e5 ("erofs: get rid of `struct z_erofs_collector'")
> Signed-off-by: Weizhao Ouyang <[email protected]>

Reviewed-by: Chao Yu <[email protected]>

Thanks,