2022-06-01 19:03:51

by Piyush Malgujar

[permalink] [raw]
Subject: [PATCH v2 0/3] net: mdio: mdio-thunder: MDIO clock related changes for Marvell Octeon Family.

This patch series mdio changes are pertaining to Marvell Octeon family.

1) clock gating:
The purpose of this change is to apply clock gating for MDIO clock
when there is no transaction happening. This will stop the MDC
clock toggling in idle scenario.

2) Marvell MDIO clock frequency attribute change:
This MDIO change provides an option for user to have the bus speed
set to their needs. The clock-freq for Marvell Octeon defaults to
3.125 MHz and not 2.5 MHz as standard. In case someone needs to use
this attribute, they have to add an extra attribute
"clock-frequency" in the mdio entry in their DTS and this driver
will do the rest.
The changes are made in a way that the clock will set to the
nearest possible value based on the clock calculation and required
frequency from DTS.

These changes has been verified internally with Marvell Octeon series.

Changes since V1:
* Separated the logical changes in separate patches
* Replaced macros with functions
* Used proper property name for DTS
* Updated DTS binding

Piyush Malgujar (3):
net: mdio: mdio-thunder: stop toggling SMI clock on idle
dt-bindings: net: cavium-mdio.txt: add clock-frequency attribute
net: mdio: mdio-thunder: support for clock-freq attribute

.../devicetree/bindings/net/cavium-mdio.txt | 5 ++
drivers/net/mdio/mdio-cavium.h | 1 +
drivers/net/mdio/mdio-thunder.c | 68 +++++++++++++++++++
3 files changed, 74 insertions(+)

--
2.17.1



2022-06-01 20:04:06

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH v2 0/3] net: mdio: mdio-thunder: MDIO clock related changes for Marvell Octeon Family.

On Mon, 30 May 2022 05:53:25 -0700 Piyush Malgujar wrote:
> This patch series mdio changes are pertaining to Marvell Octeon family.
>
> 1) clock gating:
> The purpose of this change is to apply clock gating for MDIO clock
> when there is no transaction happening. This will stop the MDC
> clock toggling in idle scenario.
>
> 2) Marvell MDIO clock frequency attribute change:
> This MDIO change provides an option for user to have the bus speed
> set to their needs. The clock-freq for Marvell Octeon defaults to
> 3.125 MHz and not 2.5 MHz as standard. In case someone needs to use
> this attribute, they have to add an extra attribute
> "clock-frequency" in the mdio entry in their DTS and this driver
> will do the rest.
> The changes are made in a way that the clock will set to the
> nearest possible value based on the clock calculation and required
> frequency from DTS.
>
> These changes has been verified internally with Marvell Octeon series.

Thanks for the patches, this does not sound like a fix tho and we're in
the middle of a merge window, so please repost on/after Monday.