2022-06-01 20:54:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH v2 2/3] dt-bindings: arm64: add BCM6858 soc

On 31/05/2022 20:46, Anand Gore wrote:
> Add BCM6858 SOC device tree description to bcmbca binding document.
>
> Signed-off-by: Anand Gore <[email protected]>


Reviewed-by: Krzysztof Kozlowski <[email protected]>


Best regards,
Krzysztof

2022-06-01 21:24:33

by Florian Fainelli

[permalink] [raw]
Subject: Re: [PATCH v2 1/3] ARM64: dts: add dts files for bcmbca SoC bcm6858



On 5/31/2022 11:46 AM, Anand Gore wrote:
> Add dts for ARMv8 based broadband SoC BCM6858.
> bcm6858.dtsi is the SoC description dts header
> and bcm96858.dts is a simple dts file for Broadcom
> BCM96858 Reference board that only enables the UART port.
>
> Signed-off-by: Anand Gore <[email protected]>
>
> ---
[snip]

> + axi@81000000 {
> + compatible = "simple-bus";
> + #address-cells = <2>;
> + #size-cells = <2>;

See my comment to William, I don't think this is quite what you want,
you should use #address-cells and #size-cells = 1 here and adjust the
reg nodes accordingly.
--
Florian