2022-06-01 18:56:17

by Max Fierke

Subject: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi CWD686

The CWD686 is a 6.86" IPS LCD panel used as the primary
display in the ClockworkPi DevTerm portable (all cores)

Signed-off-by: Max Fierke <[email protected]>
---
.../display/panel/clockworkpi,cwd686.yaml | 60 +++++++++++++++++++
1 file changed, 60 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
new file mode 100644
index 000000000000..935a33b9305f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
@@ -0,0 +1,60 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/clockworkpi,cwd686.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ClockworkPi CWD686 6.86" IPS LCD panel
+
+maintainers:
+ - Max Fierke <[email protected]>
+
+description: |
+ The ClockworkPi CWD686 is a 6.86" ICNL9707-based IPS LCD panel used within the
+ ClockworkPi DevTerm series of portable devices. The panel has a 480x1280
+ resolution and uses 24 bit RGB per pixel.
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: clockworkpi,cwd686
+
+ reg:
+ description: DSI virtual channel used by that screen
+ maxItems: 1
+
+ reset-gpios: true
+ rotation: true
+ backlight: true
+
+required:
+ - compatible
+ - reg
+ - backlight
+ - reset-gpios
+
+additionalProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/gpio/gpio.h>
+
+ backlight: backlight {
+ compatible = "gpio-backlight";
+ gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;
+ };
+
+ dsi {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ panel@0 {
+ compatible = "clockworkpi,cwd686";
+ reg = <0>;
+ backlight = <&backlight>;
+ reset-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
+ rotation = <90>;
+ };
+ };
--
2.36.1

2022-06-01 19:14:24

by Krzysztof Kozlowski

Subject: Re: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi CWD686

On 01/06/2022 07:17, Max Fierke wrote:

Subject: remove word "bindings" because you duplicate prefix, so
"dt-bindings: display: Add ClockworkPi CWD686 panel".


> +required:
> + - compatible
> + - reg
> + - backlight
> + - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;
> + };

No need for backlight example, it is trivial/same for everyone.

With that removed:

Reviewed-by: Krzysztof Kozlowski <[email protected]>

> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "clockworkpi,cwd686";
> + reg = <0>;
> + backlight = <&backlight>;
> + reset-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
> + rotation = <90>;
> + };
> + };


Best regards,
Krzysztof

2022-06-01 21:34:33

by Rob Herring (Arm)

Subject: Re: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi CWD686

On Wed, Jun 01, 2022 at 12:17:47AM -0500, Max Fierke wrote:
> The CWD686 is a 6.86" IPS LCD panel used as the primary
> display in the ClockworkPi DevTerm portable (all cores)
>
> Signed-off-by: Max Fierke <[email protected]>
> ---
> .../display/panel/clockworkpi,cwd686.yaml | 60 +++++++++++++++++++
> 1 file changed, 60 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml

You probably can simply add this to panel-simple-dsi.yaml. It mainly
depends on how many power supplies this panel has.

>
> diff --git a/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
> new file mode 100644
> index 000000000000..935a33b9305f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/clockworkpi,cwd686.yaml
> @@ -0,0 +1,60 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/clockworkpi,cwd686.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ClockworkPi CWD686 6.86" IPS LCD panel
> +
> +maintainers:
> + - Max Fierke <[email protected]>
> +
> +description: |
> + The ClockworkPi CWD686 is a 6.86" ICNL9707-based IPS LCD panel used within the
> + ClockworkPi DevTerm series of portable devices. The panel has a 480x1280
> + resolution and uses 24 bit RGB per pixel.
> +
> +allOf:
> + - $ref: panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: clockworkpi,cwd686
> +
> + reg:
> + description: DSI virtual channel used by that screen
> + maxItems: 1
> +
> + reset-gpios: true
> + rotation: true
> + backlight: true
> +
> +required:
> + - compatible
> + - reg
> + - backlight
> + - reset-gpios
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/gpio/gpio.h>
> +
> + backlight: backlight {
> + compatible = "gpio-backlight";
> + gpios = <&gpio4 30 GPIO_ACTIVE_HIGH>;
> + };
> +
> + dsi {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + panel@0 {
> + compatible = "clockworkpi,cwd686";
> + reg = <0>;
> + backlight = <&backlight>;
> + reset-gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>;
> + rotation = <90>;
> + };
> + };
> --
> 2.36.1
>
>

2022-06-02 03:54:18

by Max Fierke

Subject: Re: [PATCH 2/3] dt-bindings: display: Add bindings for ClockworkPi CWD686

On Wed, Jun 1, 2022, at 1:47 PM, Rob Herring wrote:
>
> You probably can simply add this to panel-simple-dsi.yaml. It mainly
> depends on how many power supplies this panel has.
>

Unfortunately, it does have two, a 1.8v and a 3.3v, so panel-simple-dsi.yml won't work here. On the devices on which the panel is present, they're both always on so they were left out here, but this is a good reminder that they probably should be added anyway.

Thanks,
Max