2022-06-02 04:08:31

by Jiapeng Chong

Subject: [PATCH 1/2] habanalabs: Fix kernel-doc

Fix the following W=1 kernel warnings:

drivers/misc/habanalabs/common/pci/pci.c:454: warning: expecting
prototype for hl_fw_fini(). Prototype was for hl_pci_fini() instead.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/misc/habanalabs/common/pci/pci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/misc/habanalabs/common/pci/pci.c b/drivers/misc/habanalabs/common/pci/pci.c
index 610acd4a8057..d2314157addd 100644
--- a/drivers/misc/habanalabs/common/pci/pci.c
+++ b/drivers/misc/habanalabs/common/pci/pci.c
@@ -445,7 +445,7 @@ int hl_pci_init(struct hl_device *hdev)
}

/**
- * hl_fw_fini() - PCI finalization code.
+ * hl_pci_fini() - PCI finalization code.
* @hdev: Pointer to hl_device structure
*
* Unmap PCI bars and disable PCI device.
--
2.20.1.7.g153144c

2022-06-02 05:15:32

by Jiapeng Chong

Subject: [PATCH 2/2] habanalabs: Fix kernel-doc

Fix the following W=1 kernel warnings:

drivers/misc/habanalabs/common/mmu/mmu_v1.c:425: warning: expecting
prototype for hl_mmu_fini(). Prototype was for hl_mmu_v1_fini() instead.

drivers/misc/habanalabs/common/mmu/mmu_v1.c:449: warning: expecting
prototype for hl_mmu_ctx_init(). Prototype was for hl_mmu_v1_ctx_init()
instead.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/misc/habanalabs/common/mmu/mmu_v1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
index e2d91a69acc2..ad4b49281cd7 100644
--- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
+++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
@@ -412,7 +412,7 @@ static int hl_mmu_v1_init(struct hl_device *hdev)
}

/**
- * hl_mmu_fini() - release the MMU module.
+ * hl_mmu_v1_fini() - release the MMU module.
* @hdev: habanalabs device structure.
*
* This function does the following:
@@ -438,7 +438,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev)
}

/**
- * hl_mmu_ctx_init() - initialize a context for using the MMU module.
+ * hl_mmu_v1_ctx_init() - initialize a context for using the MMU module.
* @ctx: pointer to the context structure to initialize.
*
* Initialize a mutex to protect the concurrent mapping flow, a hash to hold all
--
2.20.1.7.g153144c

2022-06-06 05:24:23

by Oded Gabbay

Subject: Re: [PATCH 2/2] habanalabs: Fix kernel-doc

On Thu, Jun 2, 2022 at 6:58 AM Jiapeng Chong
<[email protected]> wrote:
>
> Fix the following W=1 kernel warnings:
>
> drivers/misc/habanalabs/common/mmu/mmu_v1.c:425: warning: expecting
> prototype for hl_mmu_fini(). Prototype was for hl_mmu_v1_fini() instead.
>
> drivers/misc/habanalabs/common/mmu/mmu_v1.c:449: warning: expecting
> prototype for hl_mmu_ctx_init(). Prototype was for hl_mmu_v1_ctx_init()
> instead.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> drivers/misc/habanalabs/common/mmu/mmu_v1.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/misc/habanalabs/common/mmu/mmu_v1.c b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> index e2d91a69acc2..ad4b49281cd7 100644
> --- a/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> +++ b/drivers/misc/habanalabs/common/mmu/mmu_v1.c
> @@ -412,7 +412,7 @@ static int hl_mmu_v1_init(struct hl_device *hdev)
> }
>
> /**
> - * hl_mmu_fini() - release the MMU module.
> + * hl_mmu_v1_fini() - release the MMU module.
> * @hdev: habanalabs device structure.
> *
> * This function does the following:
> @@ -438,7 +438,7 @@ static void hl_mmu_v1_fini(struct hl_device *hdev)
> }
>
> /**
> - * hl_mmu_ctx_init() - initialize a context for using the MMU module.
> + * hl_mmu_v1_ctx_init() - initialize a context for using the MMU module.
> * @ctx: pointer to the context structure to initialize.
> *
> * Initialize a mutex to protect the concurrent mapping flow, a hash to hold all
> --
> 2.20.1.7.g153144c
>

Both patches are
Reviewed-by: Oded Gabbay <[email protected]>

Applied to -next.
Thanks,
Oded