2022-06-06 04:10:19

by Yannick Fertre

Subject: [PATCH] drm/stm: ltdc: remove error message about scaling

Remove error message about scaling & replace it by a debug
message to avoid too much error.

Signed-off-by: Yannick Fertre <[email protected]>
---
drivers/gpu/drm/stm/ltdc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
index eeefc3260c07..a4098aaff243 100644
--- a/drivers/gpu/drm/stm/ltdc.c
+++ b/drivers/gpu/drm/stm/ltdc.c
@@ -1215,7 +1215,8 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,

/* Reject scaling */
if (src_w != new_plane_state->crtc_w || src_h != new_plane_state->crtc_h) {
- DRM_ERROR("Scaling is not supported");
+ DRM_DEBUG_DRIVER("Scaling is not supported");
+
return -EINVAL;
}

--
2.25.1

2022-06-09 16:11:18

by Raphael Gallais-Pou

Subject: Re: [PATCH] drm/stm: ltdc: remove error message about scaling

Hi,

Thanks

Acked-by: Raphael Gallais-Pou <[email protected]>


Cheers,

Raphaël

On 6/3/22 15:42, Yannick Fertre wrote:
> Remove error message about scaling & replace it by a debug
> message to avoid too much error.
>
> Signed-off-by: Yannick Fertre <[email protected]>
> ---
> drivers/gpu/drm/stm/ltdc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index eeefc3260c07..a4098aaff243 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1215,7 +1215,8 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
>
> /* Reject scaling */
> if (src_w != new_plane_state->crtc_w || src_h != new_plane_state->crtc_h) {
> - DRM_ERROR("Scaling is not supported");
> + DRM_DEBUG_DRIVER("Scaling is not supported");
> +
> return -EINVAL;
> }
>

2022-06-27 14:38:32

by Philippe CORNU

Subject: Re: [PATCH] drm/stm: ltdc: remove error message about scaling

On 6/3/22 15:42, Yannick Fertre wrote:
> Remove error message about scaling & replace it by a debug
> message to avoid too much error.
>
> Signed-off-by: Yannick Fertre <[email protected]>
> ---
> drivers/gpu/drm/stm/ltdc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/stm/ltdc.c b/drivers/gpu/drm/stm/ltdc.c
> index eeefc3260c07..a4098aaff243 100644
> --- a/drivers/gpu/drm/stm/ltdc.c
> +++ b/drivers/gpu/drm/stm/ltdc.c
> @@ -1215,7 +1215,8 @@ static int ltdc_plane_atomic_check(struct drm_plane *plane,
>
> /* Reject scaling */
> if (src_w != new_plane_state->crtc_w || src_h != new_plane_state->crtc_h) {
> - DRM_ERROR("Scaling is not supported");
> + DRM_DEBUG_DRIVER("Scaling is not supported");
> +
> return -EINVAL;
> }
>

Dear Yannick,
Many thanks for your patch,
Applied on drm-misc-next.
Have a good day
Philippe :-)