2022-06-06 06:20:31

by Cosmin Tanislav

Subject: [PATCH v2 0/4] MAX310X I2C support

V1 -> V2:
* set_ext_reg_en -> extended_reg_enable
* move extended_reg_enable functions under guards
* move if_cfg structs under guards
* remove __maybe_unused from max310x_i2c_driver
* fix order of error labels in module register
* guard i2c register error label

Cosmin Tanislav (4):
serial: max310x: use regmap methods for SPI batch operations
serial: max310x: use a separate regmap for each port
serial: max310x: make accessing revision id interface-agnostic
serial: max310x: implement I2C support

drivers/tty/serial/Kconfig | 1 +
drivers/tty/serial/max310x.c | 261 ++++++++++++++++++++++++++---------
2 files changed, 200 insertions(+), 62 deletions(-)

--
2.36.1

2022-06-06 14:35:28

by Andy Shevchenko

Subject: Re: [PATCH v2 0/4] MAX310X I2C support

On Mon, Jun 6, 2022 at 8:08 AM Cosmin Tanislav <[email protected]> wrote:
>
> V1 -> V2:
> * set_ext_reg_en -> extended_reg_enable
> * move extended_reg_enable functions under guards
> * move if_cfg structs under guards
> * remove __maybe_unused from max310x_i2c_driver
> * fix order of error labels in module register
> * guard i2c register error label

LGTM, thanks!
Reviewed-by: Andy Shevchenko <[email protected]>

> Cosmin Tanislav (4):
> serial: max310x: use regmap methods for SPI batch operations
> serial: max310x: use a separate regmap for each port
> serial: max310x: make accessing revision id interface-agnostic
> serial: max310x: implement I2C support
>
> drivers/tty/serial/Kconfig | 1 +
> drivers/tty/serial/max310x.c | 261 ++++++++++++++++++++++++++---------
> 2 files changed, 200 insertions(+), 62 deletions(-)
>
> --
> 2.36.1
>


--
With Best Regards,
Andy Shevchenko