2022-06-07 15:50:35

by Conor Dooley

[permalink] [raw]
Subject: [PATCH net-next 0/2] Document PolarFire SoC can controller

Hey,
When adding the dts for PolarFire SoC, the can controllers were omitted,
so here they are...

Thanks,
Conor.

Conor Dooley (2):
dt-bindings: can: mpfs: document the mpfs can controller
riscv: dts: microchip: add mpfs's can controllers

.../bindings/net/can/microchip,mpfs-can.yaml | 45 +++++++++++++++++++
.../boot/dts/microchip/microchip-mpfs.dtsi | 18 ++++++++
2 files changed, 63 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml

--
2.36.1


2022-06-07 17:24:07

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH net-next 0/2] Document PolarFire SoC can controller

On 07.06.2022 07:54:58, Conor Dooley wrote:
> When adding the dts for PolarFire SoC, the can controllers were
^^^
> omitted, so here they are...

Nitpick:
Consider writing "CAN" in capital letters to avoid confusion for the not
informed reader.

Is the documentation for the CAN controller openly available? Is there a
driver somewhere?

Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


Attachments:
(No filename) (672.00 B)
signature.asc (499.00 B)
Download all attachments

2022-06-13 16:47:10

by Conor Dooley

[permalink] [raw]
Subject: Re: [PATCH net-next 0/2] Document PolarFire SoC can controller



On 13/06/2022 14:45, Marc Kleine-Budde wrote:
> On 13.06.2022 12:52:00, [email protected] wrote:
>>>> The register map cannot be downloaded directly anymore. For reference:
>>>>
>>>> http://web.archive.org/web/20220403030214/https://www.microsemi.com/document-portal/doc_download/1244581-polarfire-soc-register-map
>>>
>>> Oh that sucks. I know we have had some website issues over the weekend
>>> which might be the problem there. I'll try to bring it up and find out.
>>>
>>
>> Hey Marc,
>> Doc is still not available but should be getting fixed.
>
> Thanks.
>
>> What do I need to do for this binding? Are you happy to accept it without
>> a driver if I add links to the documentation and a working link to the
>> register map?
>
> I'm taking both patches and change the CAN into capital letters while
> applying, I'll also add a link to the datasheets.

Cool, SGTM.
Thanks,
Conor.