2022-06-08 00:52:14

by Eugen Hristev

Subject: [PATCH 1/2] ARM: dts: at91: sam9x60ek: fix eeprom compatible and size

The board has a microchip 24aa025e48 eeprom, which is a 2 Kbits memory,
so it's compatible with at24c02 not at24c32.
Also the size property is wrong, it's not 128 bytes, but 256 bytes.
Thus removing and leaving it to the default (256).

Fixes: 1e5f532c27371 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
Signed-off-by: Eugen Hristev <[email protected]>
---
arch/arm/boot/dts/at91-sam9x60ek.dts | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
index 7719ea3d4933c..81ccb0636a009 100644
--- a/arch/arm/boot/dts/at91-sam9x60ek.dts
+++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
@@ -233,10 +233,9 @@ i2c0: i2c@600 {
status = "okay";

eeprom@53 {
- compatible = "atmel,24c32";
+ compatible = "atmel,24c02";
reg = <0x53>;
pagesize = <16>;
- size = <128>;
status = "okay";
};
};
--
2.25.1

2022-06-08 05:24:17

by Eugen Hristev

Subject: [PATCH 2/2] ARM: dts: at91: sama5d2_icp: fix eeprom compatibles

The eeprom memories on the board are microchip 24aa025e48, which are 2 Kbits
and are compatible with at24c02 not at24c32.

Fixes: 68a95ef72cefe ("ARM: dts: at91: sama5d2-icp: add SAMA5D2-ICP")
Signed-off-by: Eugen Hristev <[email protected]>
---
arch/arm/boot/dts/at91-sama5d2_icp.dts | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts
index 806eb1d911d7c..164201a8fbf2d 100644
--- a/arch/arm/boot/dts/at91-sama5d2_icp.dts
+++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts
@@ -329,21 +329,21 @@ &i2c1 {
status = "okay";

eeprom@50 {
- compatible = "atmel,24c32";
+ compatible = "atmel,24c02";
reg = <0x50>;
pagesize = <16>;
status = "okay";
};

eeprom@52 {
- compatible = "atmel,24c32";
+ compatible = "atmel,24c02";
reg = <0x52>;
pagesize = <16>;
status = "disabled";
};

eeprom@53 {
- compatible = "atmel,24c32";
+ compatible = "atmel,24c02";
reg = <0x53>;
pagesize = <16>;
status = "disabled";
--
2.25.1

2022-06-08 08:45:24

by Claudiu Beznea

Subject: Re: [PATCH 1/2] ARM: dts: at91: sam9x60ek: fix eeprom compatible and size

On 07.06.2022 12:04, Eugen Hristev wrote:
> The board has a microchip 24aa025e48 eeprom, which is a 2 Kbits memory,
> so it's compatible with at24c02 not at24c32.
> Also the size property is wrong, it's not 128 bytes, but 256 bytes.
> Thus removing and leaving it to the default (256).
>
> Fixes: 1e5f532c27371 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
> Signed-off-by: Eugen Hristev <[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>


> ---
> arch/arm/boot/dts/at91-sam9x60ek.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
> index 7719ea3d4933c..81ccb0636a009 100644
> --- a/arch/arm/boot/dts/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
> @@ -233,10 +233,9 @@ i2c0: i2c@600 {
> status = "okay";
>
> eeprom@53 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x53>;
> pagesize = <16>;
> - size = <128>;
> status = "okay";
> };
> };

2022-06-08 08:45:40

by Claudiu Beznea

Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d2_icp: fix eeprom compatibles

On 07.06.2022 12:04, Eugen Hristev wrote:
> The eeprom memories on the board are microchip 24aa025e48, which are 2 Kbits
> and are compatible with at24c02 not at24c32.
>
> Fixes: 68a95ef72cefe ("ARM: dts: at91: sama5d2-icp: add SAMA5D2-ICP")
> Signed-off-by: Eugen Hristev <[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>


> ---
> arch/arm/boot/dts/at91-sama5d2_icp.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts
> index 806eb1d911d7c..164201a8fbf2d 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_icp.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts
> @@ -329,21 +329,21 @@ &i2c1 {
> status = "okay";
>
> eeprom@50 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x50>;
> pagesize = <16>;
> status = "okay";
> };
>
> eeprom@52 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x52>;
> pagesize = <16>;
> status = "disabled";
> };
>
> eeprom@53 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x53>;
> pagesize = <16>;
> status = "disabled";

2022-06-28 13:40:18

by Claudiu Beznea

Subject: Re: [PATCH 1/2] ARM: dts: at91: sam9x60ek: fix eeprom compatible and size

On 07.06.2022 12:04, Eugen Hristev wrote:
> The board has a microchip 24aa025e48 eeprom, which is a 2 Kbits memory,
> so it's compatible with at24c02 not at24c32.
> Also the size property is wrong, it's not 128 bytes, but 256 bytes.
> Thus removing and leaving it to the default (256).
>
> Fixes: 1e5f532c27371 ("ARM: dts: at91: sam9x60: add device tree for soc and board")
> Signed-off-by: Eugen Hristev <[email protected]>
Applied to at91-fixes. Thanks!

> ---
> arch/arm/boot/dts/at91-sam9x60ek.dts | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sam9x60ek.dts b/arch/arm/boot/dts/at91-sam9x60ek.dts
> index 7719ea3d4933c..81ccb0636a009 100644
> --- a/arch/arm/boot/dts/at91-sam9x60ek.dts
> +++ b/arch/arm/boot/dts/at91-sam9x60ek.dts
> @@ -233,10 +233,9 @@ i2c0: i2c@600 {
> status = "okay";
>
> eeprom@53 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x53>;
> pagesize = <16>;
> - size = <128>;
> status = "okay";
> };
> };

2022-06-28 13:57:11

by Claudiu Beznea

Subject: Re: [PATCH 2/2] ARM: dts: at91: sama5d2_icp: fix eeprom compatibles

On 07.06.2022 12:04, Eugen Hristev wrote:
> The eeprom memories on the board are microchip 24aa025e48, which are 2 Kbits
> and are compatible with at24c02 not at24c32.
>
> Fixes: 68a95ef72cefe ("ARM: dts: at91: sama5d2-icp: add SAMA5D2-ICP")
> Signed-off-by: Eugen Hristev <[email protected]>

Applied to at91-fixes. Thanks!

> ---
> arch/arm/boot/dts/at91-sama5d2_icp.dts | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/boot/dts/at91-sama5d2_icp.dts b/arch/arm/boot/dts/at91-sama5d2_icp.dts
> index 806eb1d911d7c..164201a8fbf2d 100644
> --- a/arch/arm/boot/dts/at91-sama5d2_icp.dts
> +++ b/arch/arm/boot/dts/at91-sama5d2_icp.dts
> @@ -329,21 +329,21 @@ &i2c1 {
> status = "okay";
>
> eeprom@50 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x50>;
> pagesize = <16>;
> status = "okay";
> };
>
> eeprom@52 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x52>;
> pagesize = <16>;
> status = "disabled";
> };
>
> eeprom@53 {
> - compatible = "atmel,24c32";
> + compatible = "atmel,24c02";
> reg = <0x53>;
> pagesize = <16>;
> status = "disabled";