2022-06-08 02:31:13

by Jiri Slaby

Subject: [PATCH 05/36] tty/vt: consolemap: remove extern from function decls

The extern keyword is not needed for function declarations. Remove it,
so that the consolemap header conforms to other tty headers.

Signed-off-by: Jiri Slaby <[email protected]>
---
include/linux/consolemap.h | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/include/linux/consolemap.h b/include/linux/consolemap.h
index bcfce748c9d8..abc28e4450bf 100644
--- a/include/linux/consolemap.h
+++ b/include/linux/consolemap.h
@@ -17,12 +17,11 @@
#ifdef CONFIG_CONSOLE_TRANSLATIONS
struct vc_data;

-extern u16 inverse_translate(const struct vc_data *conp, int glyph,
- int use_unicode);
-extern unsigned short *set_translate(int m, struct vc_data *vc);
-extern int conv_uni_to_pc(struct vc_data *conp, long ucs);
-extern u32 conv_8bit_to_uni(unsigned char c);
-extern int conv_uni_to_8bit(u32 uni);
+u16 inverse_translate(const struct vc_data *conp, int glyph, int use_unicode);
+unsigned short *set_translate(int m, struct vc_data *vc);
+int conv_uni_to_pc(struct vc_data *conp, long ucs);
+u32 conv_8bit_to_uni(unsigned char c);
+int conv_uni_to_8bit(u32 uni);
void console_map_init(void);
#else
#define inverse_translate(conp, glyph, uni) ((uint16_t)glyph)
--
2.36.1

2022-06-08 04:35:04

by Ilpo Järvinen

Subject: Re: [PATCH 05/36] tty/vt: consolemap: remove extern from function decls

On Tue, 7 Jun 2022, Jiri Slaby wrote:

> The extern keyword is not needed for function declarations. Remove it,
> so that the consolemap header conforms to other tty headers.
>
> Signed-off-by: Jiri Slaby <[email protected]>

Reviewed-by: Ilpo J?rvinen <[email protected]>


--
i.