2022-06-07 14:25:50

by Abel Vesa

Subject: [PATCH v9 11/12] dt-bindings: arm: freescale: scu-ocotp: Add i.MX8DXL compatible string

Add i.MX8DXL compatible string to the scu-ocotp bindings.

Signed-off-by: Abel Vesa <[email protected]>
---
.../devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml | 2 ++
1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
index 1c2d2486f366..73c9bd16ec35 100644
--- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
+++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
@@ -20,7 +20,9 @@ properties:
- enum:
- fsl,imx8qm-scu-ocotp
- fsl,imx8qxp-scu-ocotp
+ - fsl,imx8dxl-scu-ocotp
- items:
+ - const: fsl,imx8dxl-scu-ocotp
- const: fsl,imx8qxp-scu-ocotp

'#address-cells':
--
2.34.3

2022-06-28 14:47:40

by Rob Herring

Subject: Re: [PATCH v9 11/12] dt-bindings: arm: freescale: scu-ocotp: Add i.MX8DXL compatible string

On Tue, Jun 07, 2022 at 02:16:24PM +0300, Abel Vesa wrote:
> Add i.MX8DXL compatible string to the scu-ocotp bindings.
>
> Signed-off-by: Abel Vesa <[email protected]>
> ---
> .../devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml | 2 ++
> 1 file changed, 2 insertions(+)

Why are you adding this patch which adds a dependency on v9 of your
series?

>
> diff --git a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> index 1c2d2486f366..73c9bd16ec35 100644
> --- a/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> +++ b/Documentation/devicetree/bindings/arm/freescale/fsl,scu-ocotp.yaml
> @@ -20,7 +20,9 @@ properties:
> - enum:
> - fsl,imx8qm-scu-ocotp
> - fsl,imx8qxp-scu-ocotp
> + - fsl,imx8dxl-scu-ocotp
> - items:
> + - const: fsl,imx8dxl-scu-ocotp
> - const: fsl,imx8qxp-scu-ocotp

This doesn't make sense. Either you have a fallback or you don't.

>
> '#address-cells':
> --
> 2.34.3
>
>