2022-06-08 11:07:12

by Tomer Maimon

[permalink] [raw]
Subject: [PATCH v2 03/20] tty: serial: 8250: Add NPCM845 UART support

Add Nuvoton BMC NPCM845 UART support.
The NPCM845 uses the same UART as the NPCM750.

Signed-off-by: Tomer Maimon <[email protected]>
---
drivers/tty/serial/8250/8250_of.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/8250/8250_of.c b/drivers/tty/serial/8250/8250_of.c
index 5a699a1aa79c..edf83c90b4d5 100644
--- a/drivers/tty/serial/8250/8250_of.c
+++ b/drivers/tty/serial/8250/8250_of.c
@@ -335,6 +335,7 @@ static const struct of_device_id of_platform_serial_table[] = {
{ .compatible = "ti,da830-uart", .data = (void *)PORT_DA830, },
{ .compatible = "nuvoton,wpcm450-uart", .data = (void *)PORT_NPCM, },
{ .compatible = "nuvoton,npcm750-uart", .data = (void *)PORT_NPCM, },
+ { .compatible = "nuvoton,npcm845-uart", .data = (void *)PORT_NPCM, },
{ /* end of list */ },
};
MODULE_DEVICE_TABLE(of, of_platform_serial_table);
--
2.33.0


2022-06-08 14:07:41

by Tomer Maimon

[permalink] [raw]
Subject: Re: [PATCH v2 03/20] tty: serial: 8250: Add NPCM845 UART support

Hi Arnd,

Sorry but Just to clarify, This patch should not be applied and the
NPCM8XX UART should use nuvoton,npcm750-uart compatible in the device
tree?

Because I thought that in your comment a few weeks ago
https://www.spinics.net/lists/linux-serial/msg48179.html

We need only to modify the compatible string in the device tree as we
did in V2 patchset
https://www.spinics.net/lists/arm-kernel/msg986480.html

On Wed, 8 Jun 2022 at 15:01, Arnd Bergmann <[email protected]> wrote:
>
> On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <[email protected]> wrote:
> >
> > Add Nuvoton BMC NPCM845 UART support.
> > The NPCM845 uses the same UART as the NPCM750.
> >
> > Signed-off-by: Tomer Maimon <[email protected]>
>
>
> This one should no longer be needed if the timers are compatible with the
> old ones and correctly described in the DT.
>
> Arnd

Thanks,

Tomer

2022-06-08 14:07:51

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH v2 03/20] tty: serial: 8250: Add NPCM845 UART support

On Wed, Jun 8, 2022 at 11:56 AM Tomer Maimon <[email protected]> wrote:
>
> Add Nuvoton BMC NPCM845 UART support.
> The NPCM845 uses the same UART as the NPCM750.
>
> Signed-off-by: Tomer Maimon <[email protected]>


This one should no longer be needed if the timers are compatible with the
old ones and correctly described in the DT.

Arnd