Greeting,
FYI, we noticed the following commit (built with gcc-11):
commit: e1bbcd277a53e08d619ffeec56c5c9287f2bf42f ("fs: hold writers when changing mount's idmapping")
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
in testcase: xfstests
version: xfstests-x86_64-64f2596-1_20220518
with following parameters:
disk: 4HDD
fs: xfs
test: generic-group-31
ucode: 0xec
test-description: xfstests is a regression test suite for xfs and other files ystems.
test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G memory
caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
If you fix the issue, kindly add following tag
Reported-by: kernel test robot <[email protected]>
generic/633 - output mismatch (see /lkp/benchmarks/xfstests/results//generic/633.out.bad)
--- tests/generic/633.out 2022-05-18 12:17:48.000000000 +0000
+++ /lkp/benchmarks/xfstests/results//generic/633.out.bad 2022-06-07 15:37:21.117002738 +0000
@@ -1,2 +1,10 @@
QA output created by 633
Silence is golden
+idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
+idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
+idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
+idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
+idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
...
(Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/633.out /lkp/benchmarks/xfstests/results//generic/633.out.bad' to see the entire diff)
To reproduce:
git clone https://github.com/intel/lkp-tests.git
cd lkp-tests
sudo bin/lkp install job.yaml # job file is attached in this email
bin/lkp split-job --compatible job.yaml # generate the yaml file for lkp run
sudo bin/lkp run generated-yaml-file
# if come across any failure that blocks the test,
# please remove ~/.lkp and /lkp dir to run from a clean state.
--
0-DAY CI Kernel Test Service
https://01.org/lkp
On Thu, Jun 09, 2022 at 04:17:42PM +0800, kernel test robot wrote:
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-11):
>
> commit: e1bbcd277a53e08d619ffeec56c5c9287f2bf42f ("fs: hold writers when changing mount's idmapping")
> https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git master
>
> in testcase: xfstests
> version: xfstests-x86_64-64f2596-1_20220518
> with following parameters:
>
> disk: 4HDD
> fs: xfs
> test: generic-group-31
> ucode: 0xec
>
> test-description: xfstests is a regression test suite for xfs and other files ystems.
> test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
>
>
> on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz with 32G memory
>
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
>
>
>
>
> If you fix the issue, kindly add following tag
> Reported-by: kernel test robot <[email protected]>
>
>
> generic/633 - output mismatch (see /lkp/benchmarks/xfstests/results//generic/633.out.bad)
> --- tests/generic/633.out 2022-05-18 12:17:48.000000000 +0000
> +++ /lkp/benchmarks/xfstests/results//generic/633.out.bad 2022-06-07 15:37:21.117002738 +0000
> @@ -1,2 +1,10 @@
> QA output created by 633
> Silence is golden
> +idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
> +idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
> +idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
> +idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
> +idmapped-mounts.c: 8692: idmapped_mount_create_cb - Device or resource busy - failure: sys_mount_setattr
> ...
> (Run 'diff -u /lkp/benchmarks/xfstests/tests/generic/633.out /lkp/benchmarks/xfstests/results//generic/633.out.bad' to see the entire diff)
Since e1bbcd277a53 ("fs: hold writers when changing mount's idmapping")
this behavior is expected and is explained in detail in the pull request
that contained this patch.
Upstream xfstests has been updated in commit
781bb995a149 ("vfs/idmapped-mounts: remove invalid test")
and would not fail.
Thanks!
Christian
hi, Christian,
On Thu, Jun 09, 2022 at 10:39:45AM +0200, Christian Brauner wrote:
>
> Since e1bbcd277a53 ("fs: hold writers when changing mount's idmapping")
> this behavior is expected and is explained in detail in the pull request
> that contained this patch.
>
> Upstream xfstests has been updated in commit
> 781bb995a149 ("vfs/idmapped-mounts: remove invalid test")
> and would not fail.
Thanks for information! we would upgrade our xfstests.
>
> Thanks!
> Christian