The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.
While at it, add missing trailing comments to endif statements and replace
tabs before comments with whitespaces (which seems to be more common).
Juerg Haefliger (3):
ARM: s3c: Kconfig: Fix indentation
ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
ARM: s3c: Kconfig.s3c64xx: Fix indentation
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
3 files changed, 27 insertions(+), 29 deletions(-)
--
2.32.0
On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
>
> While at it, add missing trailing comments to endif statements and replace
> tabs before comments with whitespaces (which seems to be more common).
>
> [...]
Applied, thanks!
[1/3] ARM: s3c: Kconfig: Fix indentation
https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
[3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
(no commit info)
Best regards,
--
Krzysztof Kozlowski <[email protected]>
On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
>> The majority of the Kconfig files use a single tab for basic indentation
>> and a single tab followed by two whitespaces for help text indentation.
>> Fix the lines that don't follow this convention.
>>
>> While at it, add missing trailing comments to endif statements and replace
>> tabs before comments with whitespaces (which seems to be more common).
>>
>> [...]
>
> Applied, thanks!
>
> [1/3] ARM: s3c: Kconfig: Fix indentation
> https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
> (no commit info)
...And dropped. This does not pass checkpatch. Please be sure you run
scripts/checkpatch on your contributions.
WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
Haefliger <[email protected]>' != 'Signed-off-by: Juerg
Haefliger <[email protected]>'
Best regards,
Krzysztof
On Mon, 6 Jun 2022 11:14:28 +0200
Krzysztof Kozlowski <[email protected]> wrote:
> On 06/06/2022 11:13, Krzysztof Kozlowski wrote:
> > On Mon, 23 May 2022 08:42:49 +0200, Juerg Haefliger wrote:
> >> The majority of the Kconfig files use a single tab for basic indentation
> >> and a single tab followed by two whitespaces for help text indentation.
> >> Fix the lines that don't follow this convention.
> >>
> >> While at it, add missing trailing comments to endif statements and replace
> >> tabs before comments with whitespaces (which seems to be more common).
> >>
> >> [...]
> >
> > Applied, thanks!
> >
> > [1/3] ARM: s3c: Kconfig: Fix indentation
> > https://git.kernel.org/krzk/linux/c/076702da7e8a2472f8ac86f1179ddcc5e90febae
> > [3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
> > (no commit info)
>
> ...And dropped. This does not pass checkpatch. Please be sure you run
> scripts/checkpatch on your contributions.
I did and the check passed but email aliases don't work well in this scenario.
Will fix and resubmit.
...Juerg
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Juerg
> Haefliger <[email protected]>' != 'Signed-off-by: Juerg
> Haefliger <[email protected]>'
>
>
> Best regards,
> Krzysztof
The majority of the Kconfig files use a single tab for basic indentation
and a single tab followed by two whitespaces for help text indentation.
Fix the lines that don't follow this convention.
While at it, add missing trailing comments to endif statements and replace
tabs before comments with whitespaces (which seems to be more common).
v3:
- Match sob and author email addresses.
- Rebase to next-20220609.
v2 (patch 2 only):
- Mention additional changes in the commit message.
Juerg Haefliger (3):
ARM: s3c: Kconfig: Fix indentation
ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
ARM: s3c: Kconfig.s3c64xx: Fix indentation
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
arch/arm/mach-s3c/Kconfig.s3c24xx | 26 ++++++++++++--------------
arch/arm/mach-s3c/Kconfig.s3c64xx | 16 ++++++++--------
3 files changed, 27 insertions(+), 29 deletions(-)
--
2.32.0
The convention for indentation seems to be a single tab. Help text is
further indented by an additional two whitespaces. Fix the lines that
violate these rules.
Signed-off-by: Juerg Haefliger <[email protected]>
---
arch/arm/mach-s3c/Kconfig | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mach-s3c/Kconfig b/arch/arm/mach-s3c/Kconfig
index 54548c051402..a64143574546 100644
--- a/arch/arm/mach-s3c/Kconfig
+++ b/arch/arm/mach-s3c/Kconfig
@@ -43,12 +43,12 @@ config SAMSUNG_ATAGS
def_bool n
depends on ATAGS
help
- This option enables ATAGS based boot support code for
- Samsung platforms, including static platform devices, legacy
- clock, timer and interrupt initialization, etc.
+ This option enables ATAGS based boot support code for
+ Samsung platforms, including static platform devices, legacy
+ clock, timer and interrupt initialization, etc.
- Platforms that support only DT based boot need not to select
- this option.
+ Platforms that support only DT based boot need not to select
+ this option.
if SAMSUNG_ATAGS
@@ -102,7 +102,7 @@ config S3C_DEV_HSMMC3
config S3C_DEV_HWMON
bool
help
- Compile in platform device definitions for HWMON
+ Compile in platform device definitions for HWMON
config S3C_DEV_I2C1
bool
@@ -194,7 +194,7 @@ config S3C64XX_DEV_SPI0
config SAMSUNG_DEV_TS
bool
help
- Common in platform device definitions for touchscreen device
+ Common in platform device definitions for touchscreen device
config SAMSUNG_DEV_KEYPAD
bool
--
2.32.0
On Thu, 9 Jun 2022 10:21:51 +0200, Juerg Haefliger wrote:
> The majority of the Kconfig files use a single tab for basic indentation
> and a single tab followed by two whitespaces for help text indentation.
> Fix the lines that don't follow this convention.
>
> While at it, add missing trailing comments to endif statements and replace
> tabs before comments with whitespaces (which seems to be more common).
>
> [...]
Applied, thanks!
[1/3] ARM: s3c: Kconfig: Fix indentation
https://git.kernel.org/krzk/linux/c/1afde294a99d3dd2a2aa4e28d15590755927f66e
[2/3] ARM: s3c: Kconfig.s3c24xx: Fix indentation and replace some tabs
https://git.kernel.org/krzk/linux/c/48bf4b8497419f5b9a29da19c72e00dc2b8d498c
[3/3] ARM: s3c: Kconfig.s3c64xx: Fix indentation
https://git.kernel.org/krzk/linux/c/d1065293010a010261f0b1478daff40d5a3dc241
Best regards,
--
Krzysztof Kozlowski <[email protected]>