2022-06-09 09:10:15

by Srinivas Neeli

[permalink] [raw]
Subject: [PATCH V3 0/2] xilinx_can: Update on xilinx can

This patch series addresses
1) Reverts the limiting CANFD brp_min to 2.
2) Adds TDC support for Xilinx can driver.

Hi Marc,
Please apply PATCH V3 1/2 on stable branch.
Due to some mailing issue i didn't receive your mail.

Changes in V3:
-Implemented GENMASK,FIELD_PERP & FIELD_GET Calls.
-Implemented TDC feature for all Xilinx CANFD controllers.
-corrected prescalar to prescaler(typo).

Changes in V2:
- Created two patches one for revert another for TDC support.

Srinivas Neeli (2):
Revert "can: xilinx_can: Limit CANFD brp to 2"
can: xilinx_can: Add Transmitter delay compensation (TDC) feature
support

drivers/net/can/xilinx_can.c | 52 +++++++++++++++++++++++++++++++-----
1 file changed, 45 insertions(+), 7 deletions(-)

--
2.25.1


2022-06-09 09:15:27

by Srinivas Neeli

[permalink] [raw]
Subject: [PATCH V3 1/2] Revert "can: xilinx_can: Limit CANFD brp to 2"

This reverts commit 05ca14fdb6fe65614e0652d03e44b02748d25af7.

On early silicon engineering samples observed
bit shrinking issue when we use brp as 1.
Hence updated brp_min as 2. As in production
silicon this issue is fixed,so reverting the patch.

Signed-off-by: Srinivas Neeli <[email protected]>
---
Changes in V3:
-None
Changes in V2:
-New patch
---
drivers/net/can/xilinx_can.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c
index 8a3b7b103ca4..e179d311aa28 100644
--- a/drivers/net/can/xilinx_can.c
+++ b/drivers/net/can/xilinx_can.c
@@ -258,7 +258,7 @@ static const struct can_bittiming_const xcan_bittiming_const_canfd2 = {
.tseg2_min = 1,
.tseg2_max = 128,
.sjw_max = 128,
- .brp_min = 2,
+ .brp_min = 1,
.brp_max = 256,
.brp_inc = 1,
};
@@ -271,7 +271,7 @@ static const struct can_bittiming_const xcan_data_bittiming_const_canfd2 = {
.tseg2_min = 1,
.tseg2_max = 16,
.sjw_max = 16,
- .brp_min = 2,
+ .brp_min = 1,
.brp_max = 256,
.brp_inc = 1,
};
--
2.25.1

2022-06-09 09:19:09

by Marc Kleine-Budde

[permalink] [raw]
Subject: Re: [PATCH V3 0/2] xilinx_can: Update on xilinx can

On 09.06.2022 13:54:31, Srinivas Neeli wrote:
> This patch series addresses
> 1) Reverts the limiting CANFD brp_min to 2.
> 2) Adds TDC support for Xilinx can driver.

Thanks for your patches!

> Hi Marc,
> Please apply PATCH V3 1/2 on stable branch.
> Due to some mailing issue i didn't receive your mail.

Applied to can/testing, please don't mix patches for can and can-next in
on series in the future.

> Changes in V3:
> -Implemented GENMASK,FIELD_PERP & FIELD_GET Calls.
> -Implemented TDC feature for all Xilinx CANFD controllers.
> -corrected prescalar to prescaler(typo).

Pleas make this a separate patch.

regards,
Marc

--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |


Attachments:
(No filename) (925.00 B)
signature.asc (499.00 B)
Download all attachments