2022-06-11 02:20:42

by Thomas Schneider

Subject: [PATCH] HID: nintendo: Set phys property of input device based on HID phys

While the MAC address the uniq identifier is set to (cf. commit
1425247383c5 ("HID: nintendo: set controller uniq to MAC")) is certainly
unique, the physical location can be more helpful in user interfaces. The
underlying hid_device already provides a suitable value, so we can simply
reuse this here.

Signed-off-by: Thomas Schneider <[email protected]>
---
drivers/hid/hid-nintendo.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/hid/hid-nintendo.c b/drivers/hid/hid-nintendo.c
index 2204de889739..df9cd5d883c0 100644
--- a/drivers/hid/hid-nintendo.c
+++ b/drivers/hid/hid-nintendo.c
@@ -1634,6 +1634,7 @@ static int joycon_input_create(struct joycon_ctlr *ctlr)
ctlr->input->id.version = hdev->version;
ctlr->input->uniq = ctlr->mac_addr_str;
ctlr->input->name = name;
+ ctlr->input->phys = hdev->phys;
input_set_drvdata(ctlr->input, ctlr);

/* set up sticks and buttons */
@@ -1713,6 +1714,7 @@ static int joycon_input_create(struct joycon_ctlr *ctlr)
ctlr->imu_input->id.version = hdev->version;
ctlr->imu_input->uniq = ctlr->mac_addr_str;
ctlr->imu_input->name = imu_name;
+ ctlr->imu_input->phys = hdev->phys;
input_set_drvdata(ctlr->imu_input, ctlr);

/* configure imu axes */
--
2.35.1

2022-06-15 14:55:03

by Jiri Kosina

Subject: Re: [PATCH] HID: nintendo: Set phys property of input device based on HID phys

On Sat, 11 Jun 2022, Thomas Schneider wrote:

> While the MAC address the uniq identifier is set to (cf. commit
> 1425247383c5 ("HID: nintendo: set controller uniq to MAC")) is certainly
> unique, the physical location can be more helpful in user interfaces. The
> underlying hid_device already provides a suitable value, so we can simply
> reuse this here.
>
> Signed-off-by: Thomas Schneider <[email protected]>

Applied, thanks.

--
Jiri Kosina
SUSE Labs