2022-06-11 12:32:45

by Li Qiong

[permalink] [raw]
Subject: [PATCH] soc: fsl: qe: Check of ioremap return value in qe_reset

As the possible failure of the ioremap(), the qe_immr could be NULL.
Therefore it should be better to check it and print error message.

Signed-off-by: Li Qiong <[email protected]>
---
drivers/soc/fsl/qe/qe.c | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/drivers/soc/fsl/qe/qe.c b/drivers/soc/fsl/qe/qe.c
index b3c226eb5292..3c0948c2440e 100644
--- a/drivers/soc/fsl/qe/qe.c
+++ b/drivers/soc/fsl/qe/qe.c
@@ -88,6 +88,11 @@ void qe_reset(void)
if (qe_immr == NULL)
qe_immr = ioremap(get_qe_base(), QE_IMMAP_SIZE);

+ if (!qe_immr) {
+ pr_err("%s: failed to ioremap()\n", __func__);
+ return;
+ }
+
qe_snums_init();

qe_issue_cmd(QE_RESET, QE_CR_SUBBLOCK_INVALID,
--
2.11.0