2022-06-12 09:23:39

by Pali Rohár

[permalink] [raw]
Subject: Re: [PATCH] hwmon: (dell-smm) Add Dell XPS 13 7390 to fan control whitelist

On Sunday 12 June 2022 06:18:06 Armin Wolf wrote:
> A user reported that the program dell-bios-fan-control
> worked on his Dell XPS 13 7390 to switch off automatic
> fan control.
> Since it uses the same mechanism as the dell_smm_hwmon
> module, add this model to the fan control whitelist.
>
> Compile-tested only.
>
> Signed-off-by: Armin Wolf <[email protected]>

Acked-by: Pali Rohár <[email protected]>

> ---
> drivers/hwmon/dell-smm-hwmon.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/hwmon/dell-smm-hwmon.c b/drivers/hwmon/dell-smm-hwmon.c
> index 071aa6f4e109..16c10ac84a91 100644
> --- a/drivers/hwmon/dell-smm-hwmon.c
> +++ b/drivers/hwmon/dell-smm-hwmon.c
> @@ -1365,6 +1365,14 @@ static const struct dmi_system_id i8k_whitelist_fan_control[] __initconst = {
> },
> .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> },
> + {
> + .ident = "Dell XPS 13 7390",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "XPS 13 7390"),
> + },
> + .driver_data = (void *)&i8k_fan_control_data[I8K_FAN_34A3_35A3],
> + },
> { }
> };
>
> --
> 2.30.2
>