'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP).
The binding has been in use for a long time, but was never documented.
Some users and an example have a 'panel-dpi' compatible, but that's not
needed without a 'panel-timing' node which none of the users have since
commit 928faf5e3e8d ("arm64: dts: fvp: Remove panel timings"). The
example does have a 'panel-timing' node, but it should not for the
same reasons the node was removed in the dts files. So update the
example in arm,pl11x.yaml to match the schema.
Cc: Linus Walleij <[email protected]>
Cc: Robin Murphy <[email protected]>
Cc: Andre Przywara <[email protected]>
Signed-off-by: Rob Herring <[email protected]>
---
v2:
- Make arm,rtsm-display its own schema file instead of using
panel-simple.
---
.../bindings/display/arm,pl11x.yaml | 15 +----------
.../display/panel/arm,rtsm-display.yaml | 27 +++++++++++++++++++
2 files changed, 28 insertions(+), 14 deletions(-)
create mode 100644 Documentation/devicetree/bindings/display/panel/arm,rtsm-display.yaml
diff --git a/Documentation/devicetree/bindings/display/arm,pl11x.yaml b/Documentation/devicetree/bindings/display/arm,pl11x.yaml
index b545c6d20325..6cc9045e5c68 100644
--- a/Documentation/devicetree/bindings/display/arm,pl11x.yaml
+++ b/Documentation/devicetree/bindings/display/arm,pl11x.yaml
@@ -159,25 +159,12 @@ examples:
};
panel {
- compatible = "arm,rtsm-display", "panel-dpi";
- power-supply = <&vcc_supply>;
+ compatible = "arm,rtsm-display";
port {
clcd_panel: endpoint {
remote-endpoint = <&clcd_pads>;
};
};
-
- panel-timing {
- clock-frequency = <25175000>;
- hactive = <640>;
- hback-porch = <40>;
- hfront-porch = <24>;
- hsync-len = <96>;
- vactive = <480>;
- vback-porch = <32>;
- vfront-porch = <11>;
- vsync-len = <2>;
- };
};
...
diff --git a/Documentation/devicetree/bindings/display/panel/arm,rtsm-display.yaml b/Documentation/devicetree/bindings/display/panel/arm,rtsm-display.yaml
new file mode 100644
index 000000000000..4ad484f09ba3
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/arm,rtsm-display.yaml
@@ -0,0 +1,27 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/arm,rtsm-display.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Arm RTSM Virtual Platforms Display
+
+maintainers:
+ - Linus Walleij <[email protected]>
+
+allOf:
+ - $ref: panel-common.yaml#
+
+properties:
+ compatible:
+ const: arm,rtsm-display
+
+ port: true
+
+required:
+ - compatible
+ - port
+
+additionalProperties: false
+
+...
--
2.34.1
Hi Rob, thanks!
On Mon, Jun 13, 2022 at 08:57:09AM -0600, Rob Herring wrote:
> 'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP).
> The binding has been in use for a long time, but was never documented.
>
> Some users and an example have a 'panel-dpi' compatible, but that's not
> needed without a 'panel-timing' node which none of the users have since
> commit 928faf5e3e8d ("arm64: dts: fvp: Remove panel timings"). The
> example does have a 'panel-timing' node, but it should not for the
> same reasons the node was removed in the dts files. So update the
> example in arm,pl11x.yaml to match the schema.
>
> Cc: Linus Walleij <[email protected]>
> Cc: Robin Murphy <[email protected]>
> Cc: Andre Przywara <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
Acked-by: Sam Ravnborg <[email protected]>
On Mon, Jun 13, 2022 at 4:57 PM Rob Herring <[email protected]> wrote:
> 'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP).
> The binding has been in use for a long time, but was never documented.
>
> Some users and an example have a 'panel-dpi' compatible, but that's not
> needed without a 'panel-timing' node which none of the users have since
> commit 928faf5e3e8d ("arm64: dts: fvp: Remove panel timings"). The
> example does have a 'panel-timing' node, but it should not for the
> same reasons the node was removed in the dts files. So update the
> example in arm,pl11x.yaml to match the schema.
>
> Cc: Linus Walleij <[email protected]>
> Cc: Robin Murphy <[email protected]>
> Cc: Andre Przywara <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> v2:
> - Make arm,rtsm-display its own schema file instead of using
> panel-simple.
Thanks for fixing this Rob!
Reviewed-by: Linus Walleij <[email protected]>
Yours,
Linus Walleij
On Mon, 13 Jun 2022 08:57:09 -0600, Rob Herring wrote:
> 'arm,rtsm-display' is a panel for Arm, Ltd. virtual platforms (e.g. FVP).
> The binding has been in use for a long time, but was never documented.
>
> Some users and an example have a 'panel-dpi' compatible, but that's not
> needed without a 'panel-timing' node which none of the users have since
> commit 928faf5e3e8d ("arm64: dts: fvp: Remove panel timings"). The
> example does have a 'panel-timing' node, but it should not for the
> same reasons the node was removed in the dts files. So update the
> example in arm,pl11x.yaml to match the schema.
>
> Cc: Linus Walleij <[email protected]>
> Cc: Robin Murphy <[email protected]>
> Cc: Andre Przywara <[email protected]>
> Signed-off-by: Rob Herring <[email protected]>
> ---
> v2:
> - Make arm,rtsm-display its own schema file instead of using
> panel-simple.
> ---
> .../bindings/display/arm,pl11x.yaml | 15 +----------
> .../display/panel/arm,rtsm-display.yaml | 27 +++++++++++++++++++
> 2 files changed, 28 insertions(+), 14 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/display/panel/arm,rtsm-display.yaml
>
Applied, thanks!