2022-06-13 19:32:34

by Masahiro Yamada

Subject: [PATCH 3/3] s390/purgatory: remove duplicated build rule of kexec-purgatory.o

This is equivalent to the pattern rule in scripts/Makefile.build.

Having the dependency on $(obj)/purgatory.ro is enough.

Signed-off-by: Masahiro Yamada <[email protected]>
---

arch/s390/purgatory/Makefile | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/s390/purgatory/Makefile b/arch/s390/purgatory/Makefile
index 3e2c17ba04de..d237bc6841cb 100644
--- a/arch/s390/purgatory/Makefile
+++ b/arch/s390/purgatory/Makefile
@@ -48,7 +48,6 @@ OBJCOPYFLAGS_purgatory.ro += --remove-section='.note.*'
$(obj)/purgatory.ro: $(obj)/purgatory $(obj)/purgatory.chk FORCE
$(call if_changed,objcopy)

-$(obj)/kexec-purgatory.o: $(obj)/kexec-purgatory.S $(obj)/purgatory.ro FORCE
- $(call if_changed_rule,as_o_S)
+$(obj)/kexec-purgatory.o: $(obj)/purgatory.ro

obj-y += kexec-purgatory.o
--
2.32.0

2022-06-22 14:05:31

by Alexander Gordeev

Subject: Re: [PATCH 3/3] s390/purgatory: remove duplicated build rule of kexec-purgatory.o

On Tue, Jun 14, 2022 at 02:09:02AM +0900, Masahiro Yamada wrote:
> This is equivalent to the pattern rule in scripts/Makefile.build.
>
> Having the dependency on $(obj)/purgatory.ro is enough.
>
> Signed-off-by: Masahiro Yamada <[email protected]>
> ---
>
> arch/s390/purgatory/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/s390/purgatory/Makefile b/arch/s390/purgatory/Makefile
> index 3e2c17ba04de..d237bc6841cb 100644
> --- a/arch/s390/purgatory/Makefile
> +++ b/arch/s390/purgatory/Makefile
> @@ -48,7 +48,6 @@ OBJCOPYFLAGS_purgatory.ro += --remove-section='.note.*'
> $(obj)/purgatory.ro: $(obj)/purgatory $(obj)/purgatory.chk FORCE
> $(call if_changed,objcopy)
>
> -$(obj)/kexec-purgatory.o: $(obj)/kexec-purgatory.S $(obj)/purgatory.ro FORCE
> - $(call if_changed_rule,as_o_S)
> +$(obj)/kexec-purgatory.o: $(obj)/purgatory.ro
>
> obj-y += kexec-purgatory.o

Applied, thanks!

> --
> 2.32.0
>