2022-06-14 08:37:33

by Jiri Slaby

Subject: [PATCH 7/7] tty/vt: consolemap: remove dflt reset from con_do_clear_unimap()

con_do_clear_unimap() sets dflt to NULL and then calls
con_release_unimap() which does the very same as the first thing. So
remove the former as it is apparently superfluous.

Suggested-by: Ilpo Järvinen <[email protected]>
Signed-off-by: Jiri Slaby <[email protected]>
---
drivers/tty/vt/consolemap.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/tty/vt/consolemap.c b/drivers/tty/vt/consolemap.c
index 9e94ec0e0f83..5f3e58165b98 100644
--- a/drivers/tty/vt/consolemap.c
+++ b/drivers/tty/vt/consolemap.c
@@ -563,8 +563,6 @@ static int con_do_clear_unimap(struct vc_data *vc)
if (!old || old->refcount > 1)
return con_allocate_new(vc);

- if (old == dflt)
- dflt = NULL;
old->sum = 0;
con_release_unimap(old);

--
2.36.1

2022-06-14 09:06:36

by Ilpo Järvinen

Subject: Re: [PATCH 7/7] tty/vt: consolemap: remove dflt reset from con_do_clear_unimap()

On Tue, 14 Jun 2022, Jiri Slaby wrote:

> con_do_clear_unimap() sets dflt to NULL and then calls
> con_release_unimap() which does the very same as the first thing. So
> remove the former as it is apparently superfluous.
>
> Suggested-by: Ilpo J?rvinen <[email protected]>
> Signed-off-by: Jiri Slaby <[email protected]>

Reviewed-by: Ilpo J?rvinen <[email protected]>

...to all patches in this series that weren't individually replied to.

--
i.