2022-06-10 08:58:04

by Oleksij Rempel

Subject: [PATCH v1] ARM: dts: at91: ksz9477_evb: fix port/phy validation

Latest drivers version requires phy-mode to be set. Otherwise we will
use "NA" mode and the switch driver will invalidate this port mode.

Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
Signed-off-by: Oleksij Rempel <[email protected]>
---
arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts b/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts
index 443e8b022897..14af1fd6d247 100644
--- a/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts
+++ b/arch/arm/boot/dts/at91-sama5d3_ksz9477_evb.dts
@@ -120,26 +120,31 @@ ports {
port@0 {
reg = <0>;
label = "lan1";
+ phy-mode = "internal";
};

port@1 {
reg = <1>;
label = "lan2";
+ phy-mode = "internal";
};

port@2 {
reg = <2>;
label = "lan3";
+ phy-mode = "internal";
};

port@3 {
reg = <3>;
label = "lan4";
+ phy-mode = "internal";
};

port@4 {
reg = <4>;
label = "lan5";
+ phy-mode = "internal";
};

port@5 {
--
2.30.2

2022-06-15 05:44:35

by Jakub Kicinski

Subject: Re: [PATCH v1] ARM: dts: at91: ksz9477_evb: fix port/phy validation

On Fri, 10 Jun 2022 10:16:21 +0200 Oleksij Rempel wrote:
> Latest drivers version requires phy-mode to be set. Otherwise we will
> use "NA" mode and the switch driver will invalidate this port mode.
>
> Fixes: 65ac79e18120 ("net: dsa: microchip: add the phylink get_caps")
> Signed-off-by: Oleksij Rempel <[email protected]>

This got an Awaiting Upstream in patchwork along the way, but based on
Krzysztof's comment I think net is right here. So it's commit
56315b6bf7fc ("ARM: dts: at91: ksz9477_evb: fix port/phy validation")
in net now ????