2022-06-15 21:31:55

by Wolfram Sang

[permalink] [raw]
Subject: [PATCH] dt-bindings: efm32: remove bindings for deleted platform

Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform,
so no need to still carry the bindings.

Signed-off-by: Wolfram Sang <[email protected]>
---
.../devicetree/bindings/clock/efm32-clock.txt | 11 -----
.../devicetree/bindings/i2c/i2c-efm32.txt | 33 --------------
.../devicetree/bindings/serial/efm32-uart.txt | 20 ---------
.../devicetree/bindings/spi/efm32-spi.txt | 39 -----------------
include/dt-bindings/clock/efm32-cmu.h | 43 -------------------
5 files changed, 146 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/clock/efm32-clock.txt
delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-efm32.txt
delete mode 100644 Documentation/devicetree/bindings/serial/efm32-uart.txt
delete mode 100644 Documentation/devicetree/bindings/spi/efm32-spi.txt
delete mode 100644 include/dt-bindings/clock/efm32-cmu.h

diff --git a/Documentation/devicetree/bindings/clock/efm32-clock.txt b/Documentation/devicetree/bindings/clock/efm32-clock.txt
deleted file mode 100644
index 263d293f6a10..000000000000
--- a/Documentation/devicetree/bindings/clock/efm32-clock.txt
+++ /dev/null
@@ -1,11 +0,0 @@
-* Clock bindings for Energy Micro efm32 Giant Gecko's Clock Management Unit
-
-Required properties:
-- compatible: Should be "efm32gg,cmu"
-- reg: Base address and length of the register set
-- interrupts: Interrupt used by the CMU
-- #clock-cells: Should be <1>
-
-The clock consumer should specify the desired clock by having the clock ID in
-its "clocks" phandle cell. The header efm32-clk.h contains a list of available
-IDs.
diff --git a/Documentation/devicetree/bindings/i2c/i2c-efm32.txt b/Documentation/devicetree/bindings/i2c/i2c-efm32.txt
deleted file mode 100644
index 3b30e54ae3c7..000000000000
--- a/Documentation/devicetree/bindings/i2c/i2c-efm32.txt
+++ /dev/null
@@ -1,33 +0,0 @@
-* Energymicro efm32 i2c controller
-
-Required properties :
-
- - reg : Offset and length of the register set for the device
- - compatible : should be "energymicro,efm32-i2c"
- - interrupts : the interrupt number
- - clocks : reference to the module clock
-
-Recommended properties :
-
- - clock-frequency : maximal I2C bus clock frequency in Hz.
- - energymicro,location : Decides the location of the USART I/O pins.
- Allowed range : [0 .. 6]
-
-Example:
- i2c0: i2c@4000a000 {
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "energymicro,efm32-i2c";
- reg = <0x4000a000 0x400>;
- interrupts = <9>;
- clocks = <&cmu clk_HFPERCLKI2C0>;
- clock-frequency = <100000>;
- energymicro,location = <3>;
-
- eeprom@50 {
- compatible = "microchip,24c02";
- reg = <0x50>;
- pagesize = <16>;
- };
- };
-
diff --git a/Documentation/devicetree/bindings/serial/efm32-uart.txt b/Documentation/devicetree/bindings/serial/efm32-uart.txt
deleted file mode 100644
index 4f8d8fde0c1c..000000000000
--- a/Documentation/devicetree/bindings/serial/efm32-uart.txt
+++ /dev/null
@@ -1,20 +0,0 @@
-* Energymicro efm32 UART
-
-Required properties:
-- compatible : Should be "energymicro,efm32-uart"
-- reg : Address and length of the register set
-- interrupts : Should contain uart interrupt
-
-Optional properties:
-- energymicro,location : Decides the location of the USART I/O pins.
- Allowed range : [0 .. 5]
- Default: 0
-
-Example:
-
-uart@4000c400 {
- compatible = "energymicro,efm32-uart";
- reg = <0x4000c400 0x400>;
- interrupts = <15>;
- energymicro,location = <0>;
-};
diff --git a/Documentation/devicetree/bindings/spi/efm32-spi.txt b/Documentation/devicetree/bindings/spi/efm32-spi.txt
deleted file mode 100644
index e0fa61a1be0c..000000000000
--- a/Documentation/devicetree/bindings/spi/efm32-spi.txt
+++ /dev/null
@@ -1,39 +0,0 @@
-* Energy Micro EFM32 SPI
-
-Required properties:
-- #address-cells: see spi-bus.txt
-- #size-cells: see spi-bus.txt
-- compatible: should be "energymicro,efm32-spi"
-- reg: Offset and length of the register set for the controller
-- interrupts: pair specifying rx and tx irq
-- clocks: phandle to the spi clock
-- cs-gpios: see spi-bus.txt
-
-Recommended properties :
-- energymicro,location: Value to write to the ROUTE register's LOCATION
- bitfield to configure the pinmux for the device, see
- datasheet for values.
- If this property is not provided, keeping what is
- already configured in the hardware, so its either the
- reset default 0 or whatever the bootloader did.
-
-Example:
-
-spi1: spi@4000c400 { /* USART1 */
- #address-cells = <1>;
- #size-cells = <0>;
- compatible = "energymicro,efm32-spi";
- reg = <0x4000c400 0x400>;
- interrupts = <15 16>;
- clocks = <&cmu 20>;
- cs-gpios = <&gpio 51 1>; // D3
- energymicro,location = <1>;
-
- ks8851@0 {
- compatible = "ks8851";
- spi-max-frequency = <6000000>;
- reg = <0>;
- interrupt-parent = <&boardfpga>;
- interrupts = <4>;
- };
-};
diff --git a/include/dt-bindings/clock/efm32-cmu.h b/include/dt-bindings/clock/efm32-cmu.h
deleted file mode 100644
index 4b48d15fe194..000000000000
--- a/include/dt-bindings/clock/efm32-cmu.h
+++ /dev/null
@@ -1,43 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-#ifndef __DT_BINDINGS_CLOCK_EFM32_CMU_H
-#define __DT_BINDINGS_CLOCK_EFM32_CMU_H
-
-#define clk_HFXO 0
-#define clk_HFRCO 1
-#define clk_LFXO 2
-#define clk_LFRCO 3
-#define clk_ULFRCO 4
-#define clk_AUXHFRCO 5
-#define clk_HFCLKNODIV 6
-#define clk_HFCLK 7
-#define clk_HFPERCLK 8
-#define clk_HFCORECLK 9
-#define clk_LFACLK 10
-#define clk_LFBCLK 11
-#define clk_WDOGCLK 12
-#define clk_HFCORECLKDMA 13
-#define clk_HFCORECLKAES 14
-#define clk_HFCORECLKUSBC 15
-#define clk_HFCORECLKUSB 16
-#define clk_HFCORECLKLE 17
-#define clk_HFCORECLKEBI 18
-#define clk_HFPERCLKUSART0 19
-#define clk_HFPERCLKUSART1 20
-#define clk_HFPERCLKUSART2 21
-#define clk_HFPERCLKUART0 22
-#define clk_HFPERCLKUART1 23
-#define clk_HFPERCLKTIMER0 24
-#define clk_HFPERCLKTIMER1 25
-#define clk_HFPERCLKTIMER2 26
-#define clk_HFPERCLKTIMER3 27
-#define clk_HFPERCLKACMP0 28
-#define clk_HFPERCLKACMP1 29
-#define clk_HFPERCLKI2C0 30
-#define clk_HFPERCLKI2C1 31
-#define clk_HFPERCLKGPIO 32
-#define clk_HFPERCLKVCMP 33
-#define clk_HFPERCLKPRS 34
-#define clk_HFPERCLKADC0 35
-#define clk_HFPERCLKDAC0 36
-
-#endif /* __DT_BINDINGS_CLOCK_EFM32_CMU_H */
--
2.35.1


2022-06-16 00:35:44

by Stephen Boyd

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: efm32: remove bindings for deleted platform

Quoting Wolfram Sang (2022-06-15 14:07:19)
> Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform,
> so no need to still carry the bindings.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---

Acked-by: Stephen Boyd <[email protected]>

2022-06-16 08:24:34

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: efm32: remove bindings for deleted platform

On Wed, Jun 15, 2022 at 11:07:19PM +0200, Wolfram Sang wrote:
> Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform,
> so no need to still carry the bindings.

Acked-by: Mark Brown <[email protected]>


Attachments:
(No filename) (225.00 B)
signature.asc (499.00 B)
Download all attachments

2022-06-16 18:26:02

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: efm32: remove bindings for deleted platform

On Wed, 15 Jun 2022 23:07:19 +0200, Wolfram Sang wrote:
> Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform,
> so no need to still carry the bindings.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> .../devicetree/bindings/clock/efm32-clock.txt | 11 -----
> .../devicetree/bindings/i2c/i2c-efm32.txt | 33 --------------
> .../devicetree/bindings/serial/efm32-uart.txt | 20 ---------
> .../devicetree/bindings/spi/efm32-spi.txt | 39 -----------------
> include/dt-bindings/clock/efm32-cmu.h | 43 -------------------
> 5 files changed, 146 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/efm32-clock.txt
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-efm32.txt
> delete mode 100644 Documentation/devicetree/bindings/serial/efm32-uart.txt
> delete mode 100644 Documentation/devicetree/bindings/spi/efm32-spi.txt
> delete mode 100644 include/dt-bindings/clock/efm32-cmu.h
>

Deletions are automatically applied, thanks! ;)

2022-06-17 07:01:52

by Uwe Kleine-König

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: efm32: remove bindings for deleted platform

On Wed, Jun 15, 2022 at 11:07:19PM +0200, Wolfram Sang wrote:
> Commit cc6111375cec ("ARM: drop efm32 platform") removed the platform,
> so no need to still carry the bindings.
>
> Signed-off-by: Wolfram Sang <[email protected]>
> ---
> .../devicetree/bindings/clock/efm32-clock.txt | 11 -----
> .../devicetree/bindings/i2c/i2c-efm32.txt | 33 --------------
> .../devicetree/bindings/serial/efm32-uart.txt | 20 ---------
> .../devicetree/bindings/spi/efm32-spi.txt | 39 -----------------
> include/dt-bindings/clock/efm32-cmu.h | 43 -------------------
> 5 files changed, 146 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/efm32-clock.txt
> delete mode 100644 Documentation/devicetree/bindings/i2c/i2c-efm32.txt
> delete mode 100644 Documentation/devicetree/bindings/serial/efm32-uart.txt
> delete mode 100644 Documentation/devicetree/bindings/spi/efm32-spi.txt
> delete mode 100644 include/dt-bindings/clock/efm32-cmu.h

I didn't do that back then wondering if the bindings are sensible to
keep even for removed arch (or more general drivers). In this case the
chip isn't old and unavailable, but just too small for sensible Linux
usage.

OTOH I'm not aware of any dtb usage on efm32.

No hard feelings here, if you consider it not useful to keep the binding
around, go on and remove them.

Best regards
Uwe

--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | https://www.pengutronix.de/ |


Attachments:
(No filename) (1.51 kB)
signature.asc (499.00 B)
Download all attachments