2022-06-16 16:07:05

by Judy Hsiao

Subject: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s

This patch documents pinctrl-names for i2s.

Signed-off-by: Judy Hsiao <[email protected]>
---
Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
index 5ea16b8ef93f..af1069278623 100644
--- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
+++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
@@ -61,6 +61,13 @@ properties:
- const: tx
- const: rx

+ pinctrl-names:
+ oneOf:
+ - const: default
+ - items:
+ - const: bclk_on
+ - const: bclk_off
+
power-domains:
maxItems: 1

--
2.36.1.476.g0c4daa206d-goog

2022-06-16 20:42:44

by Brian Norris

Subject: Re: [PATCH v2 3/3] ASoC: dt-bindings: rockchip: Document pinctrl-names for i2s

On Thu, Jun 16, 2022 at 03:58:36PM +0000, Judy Hsiao wrote:
> This patch documents pinctrl-names for i2s.
>
> Signed-off-by: Judy Hsiao <[email protected]>
> ---
> Documentation/devicetree/bindings/sound/rockchip-i2s.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> index 5ea16b8ef93f..af1069278623 100644
> --- a/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> +++ b/Documentation/devicetree/bindings/sound/rockchip-i2s.yaml
> @@ -61,6 +61,13 @@ properties:
> - const: tx
> - const: rx
>
> + pinctrl-names:
> + oneOf:
> + - const: default
> + - items:

I'm far from a YAML expert, but I think you have the indentation wrong?
You want the "const: default" and the "items:" schema to be on the same
level of indentation, right?

If you haven't already, you might run through the 'make
dt_binding_check' process.

Brian

> + - const: bclk_on
> + - const: bclk_off
> +
> power-domains:
> maxItems: 1
>
> --
> 2.36.1.476.g0c4daa206d-goog
>