2022-06-09 19:23:06

by andrey.konovalov

Subject: [PATCH v2 1/3] mm: rename kernel_init_free_pages to kernel_init_pages

From: Andrey Konovalov <[email protected]>

Rename kernel_init_free_pages() to kernel_init_pages(). This function is
not only used for free pages but also for pages that were just allocated.

Signed-off-by: Andrey Konovalov <[email protected]>
---
mm/page_alloc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index e008a3df0485..66ef8c310dce 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -1296,7 +1296,7 @@ static inline bool should_skip_kasan_poison(struct page *page, fpi_t fpi_flags)
PageSkipKASanPoison(page);
}

-static void kernel_init_free_pages(struct page *page, int numpages)
+static void kernel_init_pages(struct page *page, int numpages)
{
int i;

@@ -1396,7 +1396,7 @@ static __always_inline bool free_pages_prepare(struct page *page,
init = false;
}
if (init)
- kernel_init_free_pages(page, 1 << order);
+ kernel_init_pages(page, 1 << order);

/*
* arch_free_page() can make the page's contents inaccessible. s390
@@ -2441,7 +2441,7 @@ inline void post_alloc_hook(struct page *page, unsigned int order,
}
/* If memory is still not initialized, do it now. */
if (init)
- kernel_init_free_pages(page, 1 << order);
+ kernel_init_pages(page, 1 << order);
/* Propagate __GFP_SKIP_KASAN_POISON to page flags. */
if (kasan_hw_tags_enabled() && (gfp_flags & __GFP_SKIP_KASAN_POISON))
SetPageSkipKASanPoison(page);
--
2.25.1

2022-06-13 17:24:20

by Muchun Song

Subject: Re: [PATCH v2 1/3] mm: rename kernel_init_free_pages to kernel_init_pages

On Thu, Jun 09, 2022 at 08:18:45PM +0200, [email protected] wrote:
> From: Andrey Konovalov <[email protected]>
>
> Rename kernel_init_free_pages() to kernel_init_pages(). This function is
> not only used for free pages but also for pages that were just allocated.
>
> Signed-off-by: Andrey Konovalov <[email protected]>

LGTM.

Reviewed-by: Muchun Song <[email protected]>

Thanks.

2022-06-17 02:25:09

by Andrew Morton

Subject: Re: [PATCH v2 1/3] mm: rename kernel_init_free_pages to kernel_init_pages

On Thu, 9 Jun 2022 20:18:45 +0200 [email protected] wrote:

> From: Andrey Konovalov <[email protected]>
>
> Rename kernel_init_free_pages() to kernel_init_pages(). This function is
> not only used for free pages but also for pages that were just allocated.
>

Not a lot of review on these three patches. I'll plan to take silence
as assent and shall move these into the mm-stable branch a few days
hence.