2022-06-18 03:02:55

by Liang He

Subject: [PATCH] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup

In init_ioports(), of_find_node_by_name() will return a node pointer
with refcount incremented. We should use of_node_put() when it is not
used anymore.

Signed-off-by: Liang He <[email protected]>
---
arch/powerpc/platforms/8xx/tqm8xx_setup.c | 3 +++
1 file changed, 3 insertions(+)

diff --git a/arch/powerpc/platforms/8xx/tqm8xx_setup.c b/arch/powerpc/platforms/8xx/tqm8xx_setup.c
index 3725d51248df..ffcfd17a5fa3 100644
--- a/arch/powerpc/platforms/8xx/tqm8xx_setup.c
+++ b/arch/powerpc/platforms/8xx/tqm8xx_setup.c
@@ -105,6 +105,9 @@ static void __init init_ioports(void)
if (dnode == NULL)
return;
prop = of_find_property(dnode, "ethernet1", &len);
+
+ of_node_put(dnode);
+
if (prop == NULL)
return;

--
2.25.1

2022-09-09 12:43:41

by Michael Ellerman

Subject: Re: [PATCH] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup

On Sat, 18 Jun 2022 10:49:30 +0800, Liang He wrote:
> In init_ioports(), of_find_node_by_name() will return a node pointer
> with refcount incremented. We should use of_node_put() when it is not
> used anymore.
>
>

Applied to powerpc/next.

[1/1] powerpc: 8xx: Fix refcount leak bug in tqm8xx_setup
https://git.kernel.org/powerpc/c/edc17890ae8ee475b566079bea2e9ba83fec021d

cheers