2022-06-09 11:24:55

by Martin Kepplinger

Subject: [PATCH v2] soc: imx: gpcv2: print errno for regulator errors

Make debugging of power management issues easier by printing the reason
why a regulator fails to be enabled or disabled.

Signed-off-by: Martin Kepplinger <[email protected]>
---

revision history
----------------
v2: (thank you Ahmad)
* use %pe format
* sent out a bit early because it's pretty obvious
v1:
https://lore.kernel.org/linux-arm-kernel/[email protected]/T/#t


drivers/soc/imx/gpcv2.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/imx/gpcv2.c b/drivers/soc/imx/gpcv2.c
index 85aa86e1338a..6383a4edc360 100644
--- a/drivers/soc/imx/gpcv2.c
+++ b/drivers/soc/imx/gpcv2.c
@@ -328,7 +328,9 @@ static int imx_pgc_power_up(struct generic_pm_domain *genpd)
if (!IS_ERR(domain->regulator)) {
ret = regulator_enable(domain->regulator);
if (ret) {
- dev_err(domain->dev, "failed to enable regulator\n");
+ dev_err(domain->dev,
+ "failed to enable regulator: %pe\n",
+ ERR_PTR(ret));
goto out_put_pm;
}
}
@@ -467,7 +469,9 @@ static int imx_pgc_power_down(struct generic_pm_domain *genpd)
if (!IS_ERR(domain->regulator)) {
ret = regulator_disable(domain->regulator);
if (ret) {
- dev_err(domain->dev, "failed to disable regulator\n");
+ dev_err(domain->dev,
+ "failed to disable regulator: %pe\n",
+ ERR_PTR(ret));
return ret;
}
}
--
2.30.2

2022-06-19 07:32:48

by Shawn Guo

Subject: Re: [PATCH v2] soc: imx: gpcv2: print errno for regulator errors

On Thu, Jun 09, 2022 at 01:17:07PM +0200, Martin Kepplinger wrote:
> Make debugging of power management issues easier by printing the reason
> why a regulator fails to be enabled or disabled.
>
> Signed-off-by: Martin Kepplinger <[email protected]>

Applied, thanks!