2022-06-17 10:34:53

by zhangzekun (A)

Subject: [PATCH -next] media:rkvdec:Remove redundant memset

As dma_alloc_coherent() will return a zeroed buffer, we
don't need to memset the returned buffer.
priv_tbl = dma_alloc_coherent() and count_tbl = dma_alloc_coherent()
should be enough.

-see commit 750afb08ca71 ("cross-tree: phase out dma_zalloc_coherent()")

Signed-off-by: Zhang Zekun <[email protected]>
---
drivers/staging/media/rkvdec/rkvdec-vp9.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/staging/media/rkvdec/rkvdec-vp9.c b/drivers/staging/media/rkvdec/rkvdec-vp9.c
index 311a12656072..c2f42e76be10 100644
--- a/drivers/staging/media/rkvdec/rkvdec-vp9.c
+++ b/drivers/staging/media/rkvdec/rkvdec-vp9.c
@@ -1015,7 +1015,6 @@ static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)

vp9_ctx->priv_tbl.size = sizeof(*priv_tbl);
vp9_ctx->priv_tbl.cpu = priv_tbl;
- memset(priv_tbl, 0, sizeof(*priv_tbl));

count_tbl = dma_alloc_coherent(rkvdec->dev, RKVDEC_VP9_COUNT_SIZE,
&vp9_ctx->count_tbl.dma, GFP_KERNEL);
@@ -1026,7 +1025,6 @@ static int rkvdec_vp9_start(struct rkvdec_ctx *ctx)

vp9_ctx->count_tbl.size = RKVDEC_VP9_COUNT_SIZE;
vp9_ctx->count_tbl.cpu = count_tbl;
- memset(count_tbl, 0, sizeof(*count_tbl));
rkvdec_init_v4l2_vp9_count_tbl(ctx);

return 0;
--
2.17.1

2022-06-20 08:09:20

by Dan Carpenter

Subject: Re: [PATCH -next] media:rkvdec:Remove redundant memset

On Fri, Jun 17, 2022 at 09:39:25AM +0000, Zhang Zekun wrote:
> As dma_alloc_coherent() will return a zeroed buffer, we
> don't need to memset the returned buffer.
> priv_tbl = dma_alloc_coherent() and count_tbl = dma_alloc_coherent()
> should be enough.
>
> -see commit 750afb08ca71 ("cross-tree: phase out dma_zalloc_coherent()")
>
> Signed-off-by: Zhang Zekun <[email protected]>
> ---

Reviewed-by: Dan Carpenter <[email protected]>

regards,
dan carpenter