2022-06-20 11:08:34

by Clément Léger

Subject: [PATCH v3 1/5] of: constify of_property_check_flags() prop argument

This argument is not modified and thus can be set as const.

Signed-off-by: Clément Léger <[email protected]>
---
include/linux/of.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/of.h b/include/linux/of.h
index f0a5d6b10c5a..d74fd82a6963 100644
--- a/include/linux/of.h
+++ b/include/linux/of.h
@@ -207,7 +207,7 @@ static inline void of_node_clear_flag(struct device_node *n, unsigned long flag)
}

#if defined(CONFIG_OF_DYNAMIC) || defined(CONFIG_SPARC)
-static inline int of_property_check_flag(struct property *p, unsigned long flag)
+static inline int of_property_check_flag(const struct property *p, unsigned long flag)
{
return test_bit(flag, &p->_flags);
}
@@ -814,7 +814,8 @@ static inline void of_node_clear_flag(struct device_node *n, unsigned long flag)
{
}

-static inline int of_property_check_flag(struct property *p, unsigned long flag)
+static inline int of_property_check_flag(const struct property *p,
+ unsigned long flag)
{
return 0;
}
--
2.36.1

2022-06-27 17:29:24

by Rob Herring (Arm)

Subject: Re: [PATCH v3 1/5] of: constify of_property_check_flags() prop argument

On Mon, Jun 20, 2022 at 12:41:19PM +0200, Cl?ment L?ger wrote:
> This argument is not modified and thus can be set as const.
>
> Signed-off-by: Cl?ment L?ger <[email protected]>
> ---
> include/linux/of.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)

I already applied this patch, don't resend it.

Rob