2022-06-20 16:22:43

by Tommaso Merciai

Subject: [PATCH v2 0/3] arm64: dts: rockchip: px30: fix ov5695 camera probe

Hi,
This series fix camera probing issue of ov5695 camera driver for px30 evb.
Improve also the ov5695.c driver using using regulator_bulk_enable/regulatore_bulk_disable
function in __ov5695_power_on/__ov5695_power_off functions instead of for loop

1. max drive-strength for cif_clkout_m0
2. add mux for mipi-pdn pad
3. use rk gpio naming convention for reset-gpio of ov5695

Note:
- This series was tested on PX30_Mini_EVB_V11_20190507 board

Tommaso Merciai (3):
arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0
arm64: dts: rockchip: px30: add mux for mipi-pdn pad
arm64: dts: rockchip: px30: use rk gpio naming convention into
reset-gpios

arch/arm64/boot/dts/rockchip/px30-evb.dts | 17 +++++++++++++++--
1 file changed, 15 insertions(+), 2 deletions(-)

--
2.25.1

2022-06-20 16:26:19

by Tommaso Merciai

Subject: [PATCH v2 1/3] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0

Add max drive-strength for cif_clkout_m0. This fix the issue that
sometimes camera ov5695 is not probed correctly.
Tested on PX30_Mini_EVB_V11_20190507

Signed-off-by: Tommaso Merciai <[email protected]>
Tested-by: Tommaso Merciai <[email protected]>
---
Changes since v1:
- Drop off 1. use regulator_bulk_enable/regulator_bulk disable instead of for
loop into ov5695 power_on/power_off

arch/arm64/boot/dts/rockchip/px30-evb.dts | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
index 73003efeec86..cc73d4bfc5b1 100644
--- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
@@ -536,6 +536,13 @@ wifi_enable_h: wifi-enable-h {
<0 RK_PA2 RK_FUNC_GPIO &pcfg_pull_none>;
};
};
+
+ cif-m0 {
+ cif_clkout_m0: cif-clkout-m0 {
+ rockchip,pins =
+ <2 RK_PB3 1 &pcfg_pull_none_12ma>;
+ };
+ };
};

&pmu_io_domains {
--
2.25.1

2022-06-20 16:45:55

by Tommaso Merciai

Subject: [PATCH v2 2/3] arm64: dts: rockchip: px30: add mux for mipi-pdn pad

Add right mux for mipi-pdn. Mux this pad as gpio2 14

Signed-off-by: Tommaso Merciai <[email protected]>
Tested-by: Tommaso Merciai <[email protected]>
---
arch/arm64/boot/dts/rockchip/px30-evb.dts | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/rockchip/px30-evb.dts b/arch/arm64/boot/dts/rockchip/px30-evb.dts
index cc73d4bfc5b1..aee7fecdfc15 100644
--- a/arch/arm64/boot/dts/rockchip/px30-evb.dts
+++ b/arch/arm64/boot/dts/rockchip/px30-evb.dts
@@ -449,8 +449,8 @@ ov5695: ov5695@36 {
dvdd-supply = <&vcc1v5_dvp>;
dovdd-supply = <&vcc1v8_dvp>;
pinctrl-names = "default";
- pinctrl-0 = <&cif_clkout_m0>;
reset-gpios = <&gpio2 14 GPIO_ACTIVE_LOW>;
+ pinctrl-0 = <&cif_clkout_m0 &mipi_pdn>;

port {
ucam_out: endpoint {
@@ -543,6 +543,12 @@ cif_clkout_m0: cif-clkout-m0 {
<2 RK_PB3 1 &pcfg_pull_none_12ma>;
};
};
+
+ mipi {
+ mipi_pdn: mipi-pdn {
+ rockchip,pins = <2 RK_PB6 RK_FUNC_GPIO &pcfg_pull_none>;
+ };
+ };
};

&pmu_io_domains {
--
2.25.1

2022-09-23 14:31:31

by Heiko Stuebner

Subject: Re: [PATCH v2 0/3] arm64: dts: rockchip: px30: fix ov5695 camera probe

On Mon, 20 Jun 2022 18:13:17 +0200, Tommaso Merciai wrote:
> This series fix camera probing issue of ov5695 camera driver for px30 evb.
> Improve also the ov5695.c driver using using regulator_bulk_enable/regulatore_bulk_disable
> function in __ov5695_power_on/__ov5695_power_off functions instead of for loop
>
> 1. max drive-strength for cif_clkout_m0
> 2. add mux for mipi-pdn pad
> 3. use rk gpio naming convention for reset-gpio of ov5695
>
> [...]

Applied, thanks!

[1/3] arm64: dts: rockchip: px30: max drive-strength for cif_clkout_m0
commit: 8cde9667137f2ca8def8aef518305a78e5f55279
[2/3] arm64: dts: rockchip: px30: add mux for mipi-pdn pad
commit: 921890cae252ed7b7e4d9f98f63515c25cc0aede
[3/3] arm64: dts: rockchip: px30: use rk gpio naming convention into reset-gpios
commit: 19d4aaf640913c5a8f1b06c9ef46287c32635299

Best regards,
--
Heiko Stuebner <[email protected]>